Skip to content

travis: fix test/integration/component/test_public_ip.py#5486

Merged
weizhouapache merged 1 commit into
apache:4.15from
shapeblue:4.15-fix-travis-test_public_ip
Sep 22, 2021
Merged

travis: fix test/integration/component/test_public_ip.py#5486
weizhouapache merged 1 commit into
apache:4.15from
shapeblue:4.15-fix-travis-test_public_ip

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Sep 21, 2021

Description

This PR fixes a travis test failure after merging PR #5464.

ROOT admin cannot list public ip address in the vlan ip ranges which are dedicated to other domain/user, we need to fix the issue in another PR.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache mentioned this pull request Sep 21, 2021
Merged
10 tasks
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 21, 2021

looks good

Currently running test: component/test_public_ip
/home/travis/.local/lib/python2.7/site-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.
  from cryptography.hazmat.backends import default_backend
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Sep_21_2021_13_06_50_S1FGB4. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_01_list_publicip_root_domain | Status : SUCCESS ===
=== TestName: test_02_list_publicip_domain_admin | Status : SUCCESS ===
=== TestName: test_03_list_publicip_user_domain | Status : SUCCESS ===
=== TestName: test_04_list_publicip_all_subdomains | Status : SUCCESS ===
=== TestName: test_05_list_publicip_user_domain | Status : SUCCESS ===
=== TestName: test_06_list_publicip_user_domain | Status : SUCCESS ===
===final results are now copied to: /tmp/MarvinLogs/test_public_ip_AK5Q6S===
real	0m21.808s
user	0m0.848s
sys	0m0.128s

re-kick the test

@weizhouapache weizhouapache reopened this Sep 21, 2021
nvazquez
nvazquez approved these changes Sep 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@weizhouapache weizhouapache reopened this Sep 21, 2021
@nvazquez nvazquez requested review from Pearl1594 and yadvr September 21, 2021 18:50
@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Sep 21, 2021

Ping for review @rhtyd @sureshanaparti @davidjumani @shwstppr @Pearl1594 - Travis passing, no further tests needed

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 22, 2021

@weizhouapache lgtm but doesn't it create an API regression?

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 22, 2021

@weizhouapache lgtm but doesn't it create an API regression?

@rhtyd as I said in the description of this PR, there is indeed an issue.
ROOT admin cannot list public ip address in the vlan ip ranges which are dedicated to other domain/user (if domain and account are not passed), we need to fix the issue in another PR.

let's merge this pr so travis test passes (it always fails for now).

@weizhouapache weizhouapache merged commit 7444bc6 into apache:4.15 Sep 22, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 22, 2021

@weizhouapache alright please submit another PR

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
travis: fix test/integration/component/test_public_ip.py (apache#5486)
261fddb 
(cherry picked from commit 7444bc6)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
weizhouapache added a commit that referenced this pull request Oct 20, 2022
@weizhouapache
Revert "travis: fix test/integration/component/test_public_ip.py (#5486…
ab36260 
…)"

This reverts commit 7444bc6.
@weizhouapache weizhouapache deleted the 4.15-fix-travis-test_public_ip branch December 9, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@yadvr yadvr Awaiting requested review from yadvr

Assignees

No one assigned

Labels

component:travis

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weizhouapache @nvazquez @yadvr