Mask libvirtd sockets which prevents cloudstack-agent from being setup by Pearl1594 · Pull Request #4756 · apache/cloudstack

Pearl1594 · 2021-03-05T05:26:46Z

Description

This PR fixes the issue of libvirtd service not starting successfully, which leads to failure in setting up of cloudstack-agent
Addresses: #4754

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested:

Issue noticed when cloudstack-setup-agent is run (while adding hosts):

[root@ref-trl-2525-k-M8-pearl-dsilva-kvm1 ~]# cloudstack-setup-agent  -m XX.XX.XX.XX -z 1 -p 1 -c 1 -g 4fe04fea-515c-4c4c-9c78-798554b483b2 -a -s  --pubNic=cloudbr1 --prvNic=cloudbr0 --guestNic=cloudbr1 --hypervisor=kvm
Starting to configure your system:
Configure SElinux ...         [OK]
Configure Network ...         [OK]
Configure Libvirt ...         [Failed]
Configuration failed for service Libvirt
Try to restore your system:
Restore SElinux ...           [OK]
Restore Network ...           [OK]
Restore Libvirt ...           [Failed]

Post Fix:

[root@ref-trl-2528-k-M8-pearl-dsilva-kvm1 ~]# cloudstack-setup-agent  -m XX.XX.XX.XX -z 1 -p 1 -c 1 -g bd24ab4a-4311-357e-8e9e-dab829448772 -a -s  --pubNic=cloudbr1 --prvNic=cloudbr0 --guestNic=cloudbr1 --hypervisor=kvm
Starting to configure your system:
Configure SElinux ...         [OK]
Configure Network ...         [OK]
Configure Libvirt ...         [OK]
Configure Firewall ...        [OK]
Configure Nfs ...             [OK]
Configure cloudAgent ...      [OK]
CloudStack Agent setup is done!

Pearl1594 · 2021-03-05T05:27:28Z

@blueorangutan package

blueorangutan · 2021-03-05T05:28:45Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2021-03-05T05:30:41Z

@Pearl1594 I think -l works with libvirtd6 as well, on Ubuntu 20.04 you need to mask few things I think. (https://rohityadav.cloud/blog/cloudstack-rpi4-kvm/#kvm-host-setup)
If need this fix, can you change PR base branch to 4.15?

Pearl1594 · 2021-03-05T05:40:50Z

@rhtyd -l doesn't seem to be working with libvirt 6.0.0, following is the exception that is noticed:

  4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 journal[4103]: libvirt version: 6.0.0, package: 28.module_el8.3.0+555+a55c8938 (CentOS Buildsys <bugs@centos.org>, 2020-11-04-01:04:00, )
Mar  4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 journal[4103]: --listen parameter not permitted with systemd activation sockets, see 'man libvirtd' for further guidance
Mar  4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 systemd[1]: libvirtd.service: Main process exited, code=exited, status=6/NOTCONFIGURED
Mar  4 09:15:09 ref-trl-2528-k-M8-pearl-dsilva-kvm1 systemd[1]: libvirtd.service: Failed with result 'exit-code'.

I've rebased the PR off 4.15

Pearl1594 · 2021-03-05T05:44:21Z

@blueorangutan package

blueorangutan · 2021-03-05T05:44:45Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2021-03-05T05:48:42Z

@Pearl1594 the errors I think are hinting towards disabling the sockets:

systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket
systemctl restart libvirtd

yadvr · 2021-03-05T05:49:21Z

Check the code wrt Ubuntu, I think the scripts do this for Ubuntu 20.04 already @Pearl1594

Pearl1594 · 2021-03-05T05:51:27Z

Thanks @rhtyd - I'll take that as reference and align to it.

blueorangutan · 2021-03-05T06:35:34Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2870

Pearl1594 · 2021-03-05T06:43:47Z

@blueorangutan package

blueorangutan · 2021-03-05T06:44:50Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-05T07:19:04Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2871

weizhouapache · 2021-03-05T08:18:20Z

Check the code wrt Ubuntu, I think the scripts do this for Ubuntu 20.04 already @Pearl1594

yep. I added the lines.
ubuntu 20.04 + cloudstack 4.15 works fine.

DaanHoogland · 2021-03-05T18:17:04Z

@blueorangutan test

blueorangutan · 2021-03-05T18:17:52Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-06T03:47:31Z

Trillian test result (tid-3669)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32338 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4756-t3669-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	59.09	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	49.05	test_vm_life_cycle.py

yadvr · 2021-03-06T09:52:51Z

@blueorangutan test centos8 kvm-centos8

blueorangutan · 2021-03-06T09:53:50Z

@rhtyd a Trillian-Jenkins test job (centos8 mgmt + kvm-centos8) has been kicked to run smoke tests

blueorangutan · 2021-03-08T13:59:46Z

Trillian test result (tid-3672)
Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
Total time taken: 31130 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4756-t3672-kvm-centos8.zip
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_oobm_background_powerstate_sync	`Failure`	21.50	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	`Failure`	8.71	test_outofbandmanagement.py
test_oobm_issue_power_cycle	`Error`	19.62	test_outofbandmanagement.py
test_oobm_issue_power_off	`Error`	19.59	test_outofbandmanagement.py
test_oobm_issue_power_on	`Error`	19.58	test_outofbandmanagement.py
test_oobm_issue_power_reset	`Error`	19.58	test_outofbandmanagement.py
test_oobm_issue_power_soft	`Error`	19.59	test_outofbandmanagement.py
test_oobm_issue_power_status	`Error`	19.60	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	`Failure`	26.58	test_outofbandmanagement.py
test_oobm_zchange_password	`Error`	7.29	test_outofbandmanagement.py
test_hostha_enable_ha_when_host_in_maintenance	`Failure`	308.69	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	8.61	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	8.57	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	9.61	test_hostha_kvm.py

shwstppr

Code changes LGTM.
OOBM tests failing with Unable to Get Channel Cipher Suites\nSet Session Privilege Level to ADMINISTRATOR failed\nError: Unable to establish IPMI v2 / RMCP+ session\n. This need to be checked

Pearl1594 force-pushed the c8-libvirt-args branch from bec676c to 8bec6df Compare March 5, 2021 05:31

Pearl1594 changed the base branch from master to 4.15 March 5, 2021 05:31

Pearl1594 changed the base branch from 4.15 to master March 5, 2021 05:31

Prevent adding --listen parameter when libvirt version > 5.6

7e38d71

Pearl1594 force-pushed the c8-libvirt-args branch from 8bec6df to 7e38d71 Compare March 5, 2021 05:37

Pearl1594 changed the base branch from master to 4.15 March 5, 2021 05:38

mask libvirtd sockets

a8a5b3c

Pearl1594 changed the title ~~Prevent adding --listen parameter when libvirt version > 5.6~~ Stop libvirtd sockets to prevent --listen parameter in LIBVIRTD_ARGS from preventing cloudstack-agent from being setup Mar 5, 2021

shwstppr reviewed Mar 5, 2021

View reviewed changes

Comment thread python/lib/cloudutils/serviceConfig.py Outdated

remove unused import

69982c9

Pearl1594 force-pushed the c8-libvirt-args branch from b08f261 to 69982c9 Compare March 5, 2021 07:38

Pearl1594 changed the title ~~Stop libvirtd sockets to prevent --listen parameter in LIBVIRTD_ARGS from preventing cloudstack-agent from being setup~~ Mask libvirtd sockets which prevents cloudstack-agent from being setup Mar 5, 2021

Pearl1594 marked this pull request as ready for review March 5, 2021 10:30

DaanHoogland added this to the 4.15.1.0 milestone Mar 5, 2021

DaanHoogland added the component:kvm label Mar 5, 2021

yadvr approved these changes Mar 6, 2021

View reviewed changes

yadvr added Severity:Critical Critical bug type:bug labels Mar 6, 2021

shwstppr approved these changes Mar 9, 2021

View reviewed changes

yadvr approved these changes Mar 11, 2021

View reviewed changes

yadvr merged commit 14366cd into apache:4.15 Mar 11, 2021

yadvr mentioned this pull request Mar 11, 2021

Add a host using systemd / libvirt > 5.6 will stop libvirt and cloudstack-agent #4754

Closed

yadvr mentioned this pull request May 25, 2021

Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0 apache/cloudstack-documentation#192

Closed

Conversation

Pearl1594 commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested:

Uh oh!

Pearl1594 commented Mar 5, 2021

Uh oh!

blueorangutan commented Mar 5, 2021

Uh oh!

yadvr commented Mar 5, 2021

Uh oh!

Pearl1594 commented Mar 5, 2021

Uh oh!

Pearl1594 commented Mar 5, 2021

Uh oh!

blueorangutan commented Mar 5, 2021

Uh oh!

yadvr commented Mar 5, 2021

Uh oh!

yadvr commented Mar 5, 2021

Uh oh!

Pearl1594 commented Mar 5, 2021

Uh oh!

blueorangutan commented Mar 5, 2021

Uh oh!

Pearl1594 commented Mar 5, 2021

Uh oh!

blueorangutan commented Mar 5, 2021

Uh oh!

blueorangutan commented Mar 5, 2021

Uh oh!

Uh oh!

weizhouapache commented Mar 5, 2021

Uh oh!

DaanHoogland commented Mar 5, 2021

Uh oh!

blueorangutan commented Mar 5, 2021

Uh oh!

blueorangutan commented Mar 6, 2021

Uh oh!

yadvr commented Mar 6, 2021

Uh oh!

blueorangutan commented Mar 6, 2021

Uh oh!

blueorangutan commented Mar 8, 2021

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Pearl1594 commented Mar 5, 2021 •

edited

Loading