Shouldn't new console kick the old one out?

Shouldn't new console kick the old one out?

@rhtyd in old ajax viewer, no

@ustcweizhou I think for the new novnc console, opening new window/session should close the previous on.
@davidjumani can you review ?

@ustcweizhou I think for the new novnc console, opening new window/session should close the previous on.
@davidjumani can you review ?

@rhtyd
there are 3 options
(1) reject new session, and keep old session.
(2) accept new session, and kick out old session
(3) keep both sessions

The current behavior (reject the first new session and accept the second new session) seems to be bug.

we have (3) in our production but the implementation is different from master.
we think (1) is better than (2).

@davidjumani @DaanHoogland @PaulAngus @andrijapanicsb your opinion ?

@rhtyd @weizhouapache Keeping both sessions should not be possible since an exclusive flag is sent when viewing the console
I'm for (1) - Reject the new and keep the old (just shorten the idle timeout)

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2481

Last time I tried to do a remote vnd - if you try to connect, it usually bounces off older/other consoles and grants the new one to be opened. What's the behaviour in old console proxy? I think if we're rejecting the new console then a suitable msg but be shown.

without any extra €0.02, option 1 has my vote but rohit's remark is valid, something like "concole session active" should do. we don't have to be verbose.

Old VNC console is to kick out the previous session.

If we do the opposite, at very least a proper message should be shown to user, while making sure that an old session is terminated after some inactivity period, otherwise a colleague helping another colleague would not be able to take over the console session, which impacts usability.

I'm personally for the old behaviour - kick off the old session (with a message explaining that another session has been established elsewhere) and allow the new session - it simply makes more sense and is more user-friendly.

um, that was me above ^^^

it looks difficult to get an decision.
would it be better to add global setting and let users choose ?

+1, with perhaps defaulting to the old VNC console behaviour (which should have been implemented in the first place)

Agree, I would prefer the original behaviour; new console should kick the old one out.

New console should not be created if an existing one is open. Kicking out the old session will cause issues especially when there are multiple users trying to access the console

That is how it worked so far @davidjumani and it allows colleagues who are jointly (remotely distanced people) troubleshooting a thing.

We all need to observe things from the user and usability perspective.

Do we have a consensus on this? Can we have new global setting to switch between new session kicking our ol session and new session being rejected?

@rhtyd
there are 3 options
(1) reject new session, and keep old session.
(2) accept new session, and kick out old session
(3) keep both sessions

The current behavior (reject the first new session and accept the second new session) seems to be bug.

I think given discussions here we should go for a tristate configuration option, letting the operator decide. Given that (2) is the old behaviour it should then be the default. agree?

+1 makes sense, go with backward compatibility

ping @ustcweizhou can you make the changes? Or introduce a global setting to toggle behaviour?

ping @ustcweizhou can you make the changes? Or introduce a global setting to toggle behaviour?

@rhtyd I will work on it.

@rhtyd @DaanHoogland @davidjumani
as discussed, updated this pr to accept new vm console session and disconnect old session.

@blueorangutan package

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2834

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3621)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33816 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4531-t3621-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below: