Skip to content

fix on changeServiceForVirtualMachine when updating read/write rate #4491

Merged
yadvr merged 3 commits into
apache:4.14from
slavkap:fix_changeServiceForVirtualMachnie
Jan 27, 2021
Merged

fix on changeServiceForVirtualMachine when updating read/write rate #4491
yadvr merged 3 commits into
apache:4.14from
slavkap:fix_changeServiceForVirtualMachnie

Conversation

@slavkap
Copy link
Copy Markdown
Contributor

@slavkap slavkap commented Nov 20, 2020 •
edited by shwstppr
Loading

When changing the service offering of a VM the disk_offering_id is not
updated in volumes DB table and VM could not start

Fixes #4125

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@slavkap
fix for changeServiceForVirtualMachnie
4f99868 
When changing the service offering of a VM the disk_offering_id is not
updated in volumes DB table and VM could not start
DaanHoogland
DaanHoogland approved these changes Nov 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Nov 21, 2020

@GabrielBrascher as this pertains to your issue can you review and verify the fix?

sureshanaparti
sureshanaparti reviewed Nov 24, 2020
View reviewed changes
Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated
sureshanaparti
sureshanaparti reviewed Nov 24, 2020
View reviewed changes
Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
sureshanaparti
sureshanaparti approved these changes Nov 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM, haven't tested

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Nov 27, 2020

@GabrielBrascher i suppose this will wait for 4.14.2?

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 21, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 21, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 21, 2020

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2502

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 21, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 21, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@sureshanaparti sureshanaparti changed the title fix on changeServiceForVirtualMachnie when updating read/write rate fix on changeServiceForVirtualMachine when updating read/write rate Dec 23, 2020
@shwstppr shwstppr added this to the 4.14.1.0 milestone Jan 25, 2021
@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Jan 25, 2021

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 25, 2021

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 25, 2021

Trillian test result (tid-3410)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39374 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4491-t3410-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_upgrade_kubernetes_cluster Failure 234.29 test_kubernetes_clusters.py

shwstppr
shwstppr approved these changes Jan 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code changes and test results

@GabrielBrascher can you please review this

@yadvr yadvr merged commit 4a779de into apache:4.14 Jan 27, 2021
@shwstppr shwstppr mentioned this pull request Feb 4, 2021
Merged
12 tasks
@Pearl1594 Pearl1594 mentioned this pull request Feb 4, 2021
Merged
12 tasks
@sureshanaparti sureshanaparti mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

Severity:Major type:bug

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@slavkap @DaanHoogland @yadvr @blueorangutan @shwstppr @sureshanaparti