Skip to content

Fix: Data migration#4475

Merged
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:sec-stg-regression
Nov 18, 2020
Merged

Fix: Data migration#4475
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:sec-stg-regression

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Nov 17, 2020

Description

This PR fixes a regression that was caused due to the following commit: d864e9d - which reverted the handler for data migration introduced by #4053.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

Performed data migration operation and verified the behavior - performed against all hypervisors

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Nov 17, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2020

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland added this to the 4.15.0.0 milestone Nov 17, 2020
DaanHoogland
DaanHoogland approved these changes Nov 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. this merge that caused the regression is rather big. Can we make any conclusions as to how much has been broken by it @Pearl1594 ?

image

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2389

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 17, 2020

@DaanHoogland I only see 20 line changes

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2020

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Nov 17, 2020

@DaanHoogland I could only identify the changes that we made by me that got reverted by the commit - mainly the FSM changes in VolumeObject class and the handler in the BaseImageStoreDriverImpl class were the major breaking reverts

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Nov 17, 2020

I'm referring to the commit that caused the regression, @rhtyd . it has about 6000 lines changed in 127 files. this is the second regression due to that one.

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Nov 17, 2020

I'm referring to the commit that caused the regression, @rhtyd . it has about 6000 lines changed in 127 files. this is the second regression due to that one.

@DaanHoogland hope there is no more regression.
by the way. is 4.15 LTS ?

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Nov 17, 2020

I'm referring to the commit that caused the regression, @rhtyd . it has about 6000 lines changed in 127 files. this is the second regression due to that one.

@DaanHoogland hope there is no more regression.
by the way. is 4.15 LTS ?

I'm actually not sure. It is not added to https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS yet. @PaulAngus 4.15 is supposed to be an LTS release is it?

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2020

Trillian test result (tid-3184)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32596 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4475-t3184-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_scale_vm Failure 10.39 test_scale_vm.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2020

Trillian test result (tid-3185)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35365 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4475-t3185-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_upgrade_kubernetes_cluster Failure 238.00 test_kubernetes_clusters.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2020

Trillian test result (tid-3186)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4475-t3186-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_upgrade_kubernetes_cluster Failure 787.57 test_kubernetes_clusters.py

@DaanHoogland DaanHoogland merged commit 1dbb76f into apache:master Nov 18, 2020
@DaanHoogland DaanHoogland deleted the sec-stg-regression branch November 18, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

Assignees

No one assigned

Labels

Severity:BLOCKER type:bug type:regression

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Pearl1594 @blueorangutan @yadvr @DaanHoogland @weizhouapache @harikrishna-patnala