Skip to content

Adding acl name to listNetworkAcl, listNetwork, listPrivateGateway, listVpcs responses#4315

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:add-acl-name
Sep 17, 2020
Merged

Adding acl name to listNetworkAcl, listNetwork, listPrivateGateway, listVpcs responses#4315
yadvr merged 1 commit into
apache:masterfrom
shapeblue:add-acl-name

Conversation

@davidjumani
Copy link
Copy Markdown
Contributor

@davidjumani davidjumani commented Sep 10, 2020 •
edited
Loading

Description

Adding acl name to listNetworkAcl, listNetwork, listPrivateGateway, listVpcs responses

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

(localhost) 🐱 > list vpcs
{
  "count": 1,
  "vpc": [
    {
      "network": [
        {
          "aclid": "4a8a6365-f329-11ea-9aba-50eb71576f75",
          "aclname": "default_allow",
           ..........
    }
  ]
}


(localhost) 🐱 > list networks
{
  "count": 1,
  "network": [
    {
      "aclid": "4a8a6365-f329-11ea-9aba-50eb71576f75",
      "aclname": "default_allow",
       ..........
    }
  ]
}


(localhost) 🐱 > list networkacls 
{
  "count": 4,
  "networkacl": [
    {
      "aclid": "4a8a6365-f329-11ea-9aba-50eb71576f75",
      "aclname": "default_allow",
       ..........
    }
  ]
}

(localhost) 🐱 > list privategateways 
{
  "count": 1,
  "privategateway": [
    {

      "aclid": "4a8a4c78-f329-11ea-9aba-50eb71576f75",
      "aclname": "default_deny",
       ..........
    }
  ]
}

@davidjumani
Copy link
Copy Markdown
Contributor Author

davidjumani commented Sep 10, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2020

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1949

@davidjumani davidjumani marked this pull request as ready for review September 11, 2020 09:15
@yadvr yadvr added this to the 4.15.0.0 milestone Sep 11, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 13, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 13, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 13, 2020

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1984

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Sep 15, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 15, 2020

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 15, 2020

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2003

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 15, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 15, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@davidjumani
Copy link
Copy Markdown
Contributor Author

davidjumani commented Sep 15, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 15, 2020

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 15, 2020

Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2006

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 15, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 15, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

shwstppr
shwstppr approved these changes Sep 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on changes but new API response params don't have since tag @davidjumani

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 16, 2020

Trillian test result (tid-2760)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37344 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4315-t2760-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_hostha_kvm_host_fencing Error 97.84 test_hostha_kvm.py

@yadvr yadvr merged commit 44bc134 into apache:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

Assignees

No one assigned

Labels

component:api component:primate type:enhancement

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@davidjumani @blueorangutan @yadvr @shwstppr @DaanHoogland