Skip to content

cks: fix logging exception on create cluster#4309

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix-cks-issues
Sep 17, 2020
Merged

cks: fix logging exception on create cluster#4309
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix-cks-issues

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Sep 8, 2020 •
edited
Loading

Description

Fix for exception in logging while creating k8s cluster

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Sep 8, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2020

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2020

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1916

@shwstppr
fix logging exception
3be4e72 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr changed the base branch from 4.14 to master September 8, 2020 07:02
@shwstppr shwstppr changed the title cks: assorted fixes for template, network, capacity cks: fix logging exception on create cluster Sep 8, 2020
@shwstppr shwstppr mentioned this pull request Sep 8, 2020
Merged
5 tasks
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1918

@yadvr yadvr added this to the 4.15.0.0 milestone Sep 8, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 9, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 9, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

davidjumani
davidjumani approved these changes Sep 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! LGTM!

@yadvr yadvr marked this pull request as ready for review September 17, 2020 04:46
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 17, 2020

Only logging fix, merging based on Travis

@yadvr yadvr merged commit 87e08f8 into apache:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@davidjumani davidjumani davidjumani approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

Severity:Trivial type:bug

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr @blueorangutan @yadvr @davidjumani @Pearl1594 @DaanHoogland