Move the snapshotDao.remove(snapshotId);#4006
Merged
Merged
Conversation
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 2, 2020
andrijapanicsb
added a commit
that referenced
this pull request
Apr 11, 2020
* Fixes snapshot deletion * Remove legacy '@component', it is not necessary in this bean/class. * Fix log message missing %d and remove snapshot on DB * Remove "dummy" boolean return statement * Manage snapshot deletion for KVM + NFS (primary storage) * checkstyle trailing spaces * rename options strings to *_OPTION * Fix typo on deleteSnapshotOnSecondaryStorage and enhance log message * Move the snapshotDao.remove(snapshotId); (#4006) * Fix deletesnapshot worflow to handle both snapshots created in primary storage and snapshots backed up to secondary storage * Fix extra space * refactor out separate handling methods for secondary and primary (reducing returns) * return false on unexpected error or log when expected * != instead of == * secondary instead of backup storage * init to null * Handle snapshot deletion on primary storage. When primary store ref not found for snapshot do not fail the operation. * Fix debug levels on log messages Co-authored-by: GabrielBrascher <gabriel@apache.org> Co-authored-by: Andrija Panic <45762285+andrijapanicsb@users.noreply.github.com> Co-authored-by: Harikrishna Patnala <harikrishna.patnala@gmail.com> Co-authored-by: nvazquez <nicovazquez90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.