Revert of the "Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt""#3772
Conversation
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@svenvogel @DennisKonrad please review this PR (revert of the revert = same PR as the original one #3371 that you guys created. I'm doing another round of automated tests on this one and will be ready for merging based on all LGTMs on the original PR @weizhouapache may I kindly ask you for the opinion if PR looks good (equivalent to original PR 3371) - I've done checks myslef, but prefer another opinion please. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-482 |
svenvogel
left a comment
There was a problem hiding this comment.
@andrijapanicsb the revert of the revert of my #3371 looks good. its the same we had already other LGTM from @mike-tutkowski @syed and @weizhouapache
|
@blueorangutan test |
|
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
LGTM 👍 |
|
Tests failed silently, re-running: @blueorangutan test |
|
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@blueorangutan package |
cf493b6 to
2daf19b
Compare
|
@blueorangutan package |
|
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-487 |
|
@blueorangutan test |
|
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
You have to LOVE!!! the Epel repo issues 🤦♂ @blueorangutan test |
|
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@andrijapanicsb whaaat? okay i understand. so i can add this to spec file as a dependency. can i update my PR if its under your name? |
|
no @svenvogel - there are constant issues with EPEL repo (which Trillian is using for some packages), mirrors don't sync properly due to soruce issues - so the Trillian build jobs just fails... |
|
ok tests are finally running... need a few hours for the results. |
|
Trillian test result (tid-646)
|
|
Based on all the LGTMs on this one (and the original #3371) and the KVM automated tests - I'm merging this one. |
… / refactor cloud-install-sys-tmplt (apache#3371)" (apache#3771)" (apache#3772) This reverts commit e319c8b.
The original PR #3371 was merged without Trillian tests being done, so I have reverted the merge by creating (via GitHub) the PR #3771
Then, tests were done on the original PR 3371, showing NO regression (77 tests fine, 0 failed), so it is (with all the other LGTMs) safe to merge it after all.
I'm thus creating this PR which is the revert of the revert (3771) of the original PR 3371 - i.e. same PR as the original one.
Will run tests again and ask for LGTMs before finally merging it.