Skip to content

Fix 3 more findbugs performance alerts, creating boxed Long and Integer unnecessarily #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsafonseca wants to merge 1 commit into from
Closed

Fix 3 more findbugs performance alerts, creating boxed Long and Integer unnecessarily #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ private synchronized Answer execute(IpAssocCommand cmd, int numRetries) {
for (IpAddressTO ip : ips) {
// is it saver to use Long.valueOf(BroadcastDomain.getValue(ip.getBroadcastUri())) ???
// i.o.w. can this contain vlan:// then change !!!
long guestVlanTag = Long.valueOf(ip.getBroadcastUri());
long guestVlanTag = Long.parseLong(ip.getBroadcastUri());
// It's a hack, using isOneToOneNat field for indicate if it's inline or not
boolean inline = ip.isOneToOneNat();
String vlanSelfIp = inline ? tagAddressWithRouteDomain(ip.getVlanGateway(), guestVlanTag) : ip.getVlanGateway();
Expand Down Expand Up @@ -700,7 +700,7 @@ private void deleteVirtualServerAndDefaultPool(String virtualServerName) throws
List<String> poolMembers = getMembers(virtualServerName);
for (String poolMember : poolMembers) {
String[] destIpAndPort = getIpAndPort(poolMember);
deletePoolMember(virtualServerName, destIpAndPort[0], Integer.valueOf(destIpAndPort[1]));
deletePoolMember(virtualServerName, destIpAndPort[0], Integer.parseInt(destIpAndPort[1]));
}

// Delete the virtual server
Expand Down Expand Up @@ -886,7 +886,7 @@ private void deleteInactivePoolMembers(String virtualServerName, List<String> ac
for (String member : allPoolMembers) {
if (!activePoolMembers.contains(member)) {
String[] ipAndPort = member.split("-");
deletePoolMember(virtualServerName, ipAndPort[0], Integer.valueOf(ipAndPort[1]));
deletePoolMember(virtualServerName, ipAndPort[0], Integer.parseInt(ipAndPort[1]));
}
}
}
Expand Down