Allow custom command role ACL files on classpath in Static Role API Checker#354
Allow custom command role ACL files on classpath in Static Role API Checker#354ProjectMoon wants to merge 1 commit into
Conversation
|
cloudstack-pull-requests #301 FAILURE |
|
Looks like the Oracle VM3 build failed in the pul request check. Is that a problem on the master branch currently? |
|
LGTM, though we need to test it by producing packages. In theory, the /etc/cloudstack/management should be on classpath so this should work. |
|
Is there anything I can do to assist with the testing? |
|
@ProjectMoon can you share any test results? Is the spring xml gets into the compiled jar from users' perspective, how may I configure a different properties file, any docs in this regard? |
|
This would be a step-by-step way of how I tested the change. We will use mycommands.properties as the example.
In a production environment the administrator would just drop a new properties file on the classpath somewhere, typically the classes directory of WEB-INF. |
|
@ProjectMoon my concern here is -- you're still making changes in the XML to make it work during build time, is there a way to make it configurable like rabbitmq plugin so one can add the xml at some place in /etc/cloudstack/management to change/add file names in the XML. (pardon my ignorance, I'm not well versed with spring) |
|
Yes, that is correct it would need to be done during build time. I can add a way to make the list of files configurable. I think it would be best to make a properties file that has a key and a comma-separated list of files to find on the classpath. I don't want to stick make a new properties file with just one line though. Are there any properties file that go into /etc/cloudstack/management where I could stick this key-value? |
|
@ProjectMoon can you rebase and re-submit the PR, the travis tests seems to be failing. |
|
Pull request branch has been updated. |
|
cloudstack-pull-requests #489 FAILURE |
|
cloudstack-pull-requests #490 SUCCESS |
…hecker. This commit has a small refactoring of cloud-plugin-acl-static-role-based to allow it to read files on the classpath that might have a different name than "commands.properties". It also allows more than one file to be read from. Rationale: Third-party plugins may want to keep their API command access level configuration separate from the main file so as to reduce configuration maintenance work during packaging and deployments.
|
cloudstack-pull-requests #654 SUCCESS |
|
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Commit Message
This commit has a small refactoring of cloud-plugin-acl-static-role-based
to allow it to read files on the classpath that might have a different name
than "commands.properties". It also allows more than one file to be read from.
Rationale: Third-party plugins may want to keep their API command access level
configuration separate from the main file so as to reduce configuration
maintenance work during packaging and deployments.
Testing Performed
Ran the simulator locally and connected to it with Cloudmonkey. Ran sync and then executed some API commands to verify that they are not blacklisted (i.e. not found because CS could not read the file on the classpath).