Skip to content

server: sync templates on adding new secondary storage#3302

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix-sec-storage-templates-2689
Apr 29, 2019
Merged

server: sync templates on adding new secondary storage#3302
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix-sec-storage-templates-2689

Conversation

@shwstppr

@shwstppr shwstppr commented Apr 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #2689

With the current code, existing templates were not downloaded to the new secondary storage when it is added. SSVM needed to be restarted to start the download process. This PR starts templates sync for the new secondary storage when it is added.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Using KVM based monkeybox environment. New secondary storage was added and template download was verified by listing files for the storage.

@shwstppr
server: sync templates on adding new secondary storage
9749b5d 
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@DaanHoogland

DaanHoogland commented Apr 29, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Apr 29, 2019

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Apr 29, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2722

@DaanHoogland

DaanHoogland commented Apr 29, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Apr 29, 2019

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 29, 2019

Copy link
Copy Markdown

Trillian test result (tid-3541)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33687 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3302-t3541-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr added this to the 4.13.0.0 milestone Apr 29, 2019
@yadvr yadvr added the type:bug label Apr 29, 2019
@yadvr yadvr merged commit 6dad46b into apache:master Apr 29, 2019
@shwstppr shwstppr mentioned this pull request Jul 30, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

type:bug

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

Existing templates not downloaded when adding new secondary storage

4 participants

@shwstppr @DaanHoogland @blueorangutan @yadvr