Skip to content

Remove deprecated buildw and wix plugin#2849

Merged
yadvr merged 1 commit into
apache:masterfrom
khos2ow:remove-wix-buildw
Oct 4, 2018
Merged

Remove deprecated buildw and wix plugin#2849
yadvr merged 1 commit into
apache:masterfrom
khos2ow:remove-wix-buildw

Conversation

@khos2ow
Copy link
Copy Markdown
Contributor

@khos2ow khos2ow commented Sep 18, 2018

Description

This PR removes deprecated and obsolete wix plugin and corresponding buildw to build Windows related artifacts.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: #2771

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@rafaelweingartner rafaelweingartner modified the milestones: 4.11.2.0, 4.12.0.0 Sep 18, 2018
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 21, 2018

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 21, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 21, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2314

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 21, 2018

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 21, 2018

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 21, 2018

Trillian test result (tid-3037)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28639 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2849-t3037-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 67 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_nic_secondaryip_add_remove Error 39.00 test_multipleips_per_nic.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 1162.14 test_privategw_acl.py

DaanHoogland
DaanHoogland approved these changes Sep 22, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, test failures probably unrelated

dhlaluku
dhlaluku approved these changes Sep 29, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhlaluku dhlaluku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup. Lets keep up the good work

@yadvr yadvr merged commit 769a008 into apache:master Oct 4, 2018
@khos2ow khos2ow deleted the remove-wix-buildw branch October 4, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

+1 more reviewer

@dhlaluku dhlaluku dhlaluku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@khos2ow khos2ow

Labels

type:cleanup

Projects

None yet

Milestone

4.12.0.0

Development

Successfully merging this pull request may close these issues.

Followup 2613: remove buildw profile and tools/wix-cloudstack-maven-plugin

7 participants

@khos2ow @yadvr @blueorangutan @DaanHoogland @borisstoyanov @dhlaluku @rafaelweingartner