Cleanup POMs#2613
Conversation
| <extension>WixUIExtension</extension> | ||
| <extension>WixUtilExtension</extension> | ||
| </extensions> | ||
| <arguments>-dSourceClient=SourceDir\client -dS |
There was a problem hiding this comment.
Isn't it going to fail the execution since the arguments are on multiple line now?
There was a problem hiding this comment.
That's a very good point, I haven't tested buildw profile!
There was a problem hiding this comment.
Isn't this the profile that was intended to build ACs for windows as an executable file?
I never understood this Wix project that we have.
There was a problem hiding this comment.
I believe so. This is actually my first time trying to execute it.
There was a problem hiding this comment.
I would not even bother. CloudStack does not work on Windows. I mean, executing the management server on Windows (do not confuse with ACS using Hyper-V). I think this component was added to ACS in the dark ages when code was committed without much reviewing and thinking.
There was a problem hiding this comment.
Makes sense, its' not even in here. I'll do some digging the history, then I might remove the whole thing.
There was a problem hiding this comment.
So the wix project and its workflow was last updated 4 years ago, and it's fully broken since Embedded Jetty commit (July 2017). although I couldn't manage to make it work after fixing that part of it.
Besides that, I wasn't able to find any guide anywhere that Cloudstack actually can be installed on Windows. (4.5, 4.6, 4.7, 4.8, 4.9, 4.11)
I'll send an email to ML, but I guess we can safely delete Wix-* and buildw altogether.
There was a problem hiding this comment.
This Wix project was already on my TODO list to remove it. If you look at the code base of ACS, you will notice that even though ACS is written in Java (therefore it seems it could be easily executed on Windows), there are quite a lot of dependencies on Linux operating system. Here there are some details of the port to windows that were left unfinished [1].
We have a protocol to execute the plugin/component retirement. You can read it here [2]. Thanks for picking that up!
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication
[2] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68720798
There was a problem hiding this comment.
That's great, although I think six months is very long for something which is already stalled. Specially that in most cases when retirement proposal happens, that piece of code must have been obsolete for months, if not years.
| <dependency> | ||
| <groupId>org.apache.tomcat.embed</groupId> | ||
| <artifactId>tomcat-embed-core</artifactId> | ||
| <version>8.0.30</version> |
There was a problem hiding this comment.
Can you move the version to the global pom into the properties section?
|
@blueorangutan package |
|
@khos2ow a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1988 |
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM. Good work @khos2ow
|
@blueorangutan package |
|
@khos2ow a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2003 |
|
debian failed @khos2ow . not sure if it is helpful but here is the last few log lines of the job: not sure if it should matter either ;) |
|
Thanks @DaanHoogland, it is fixed already, I haven't pushed yet. |
|
@blueorangutan package |
|
@khos2ow a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2011 |
|
@DaanHoogland it's still failing. Are you running customized command for building deb packages? I cannot reproduce this. |
|
This PR should be good now. Call for reviewing: @rhtyd @rafaelweingartner @marcaurele @DaanHoogland @GabrielBrascher @wido @borisroman @swill |
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@DaanHoogland and @rhtyd how do we merge this? I am inclined to accept it as soon as packaging is fine. |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2027 |
|
Can any one who has access to packaging job, provide me some log to see why debian packaging fails? And also the command/script is used to trigger the job. |
|
I built the BTW: I used |
|
Thanks @rafaelweingartner for validating the packaging, that's why I'm guessing the way BO does the packaging is somehow broken/different/hacked, or simply does something which I haven't foreseen? |
|
@khos2ow anyone can just rekick pkgs with bo. Sometimes jobs fail due to network, io or test related issue. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@rhtyd thanks for the explanation, but that would be a surprising coincidence and I would say unlikely, since both packaging job - after the debian fix - failed. |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2031 |
|
@blueorangutan package |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@khos2ow do you have an idea about why Jenkins is failing? |
|
@rafaelweingartner hmm, not sure, let me just push an empty commit to kick it off again. |
|
@rafaelweingartner it might be because of timeout issue of some sorts. previously PMD wasn't running for all the projects which this PR changes that, and it breaks at the end of the job while preparing PMD reports: The last |
|
Well, I saw the message: However, if it was a job timeout, should we see a "job timeout" message? |
|
BTW: Who has write access to the build "https://builds.apache.org/job/cloudstack-pr-analysis/" to check its timeout configurations? @DaanHoogland, @wido, @swill, and @rhtyd |
|
I think I do, @rafaelweingartner . What is needed? remember there was a github webhook outage this week, btw. |
|
@DaanHoogland we need to check the timeout configuration. And then, if it is not enough for us, we need to increase it. BTW: can you give me permission to see these configuration at Jenkins as well? |
|
@rafaelweingartner according to this, the crash happened most probably because of running out of memory and not timeout. |
|
@khos2ow would you mind moving the PMD change to another PR to help getting this one in? |
|
@marcaurele done, let's see how much Jenkins likes this change! |
|
@rhtyd @rafaelweingartner @marcaurele @borisstoyanov @DaanHoogland this PR should be good to be merged, I also added |
|
@khos2ow what about creating issues for those TODOs? |
|
I was going to create those issues after this got merged and those actually became issues. |
|
@rafaelweingartner corresponding issues have been created. |
|
Danke! |
Description
In this PR I'm trying to cleanup POMs. The main changes are:
SPACEs instead of 2)services/console-proxy-rdp/rdbconsoleunderservices/console-proxyRemoveservices/iam(as of ba84808) [open for discussion]Removing theiamprojects doesn't have any side effect, although there are lots of leftover testsRemovetools/wix-cloudstack-maven-pluginengineframeworkpluginsservicescheckstyleplugin to run in all required projectsPMDplugin to be executed on all projects onenablefindbugsprofileFor simplicity of reviewing, I pushed in different commits, eventually we can squash them.
TODO and followups after this PR gets merged
enablefindbugsprofilebuildwprofile andtools/wix-cloudstack-maven-pluginservices/iamprojectTypes of changes
How Has This Been Tested?
mvn -P developer,systemvm -Dsimulator -Dnoredist --projects='org.apache.cloudstack:cloudstack' org.apache.rat:apache-rat-plugin:0.12:checkmvn install -P developer -P systemvm -Dsimulator -Dnoredistmvn install -P enablefindbugs cobertura:coberturamvn -P developer -pl developer -Ddeploydbmvn -P developer -pl developer -Ddeploydb-simulatorChecklist:
Testing