Skip to content

CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables#2506

Merged
yadvr merged 5 commits into
apache:4.11from
shapeblue:sysvmdisk-smaller
Mar 28, 2018
Merged

CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables#2506
yadvr merged 5 commits into
apache:4.11from
shapeblue:sysvmdisk-smaller

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Mar 23, 2018 •
edited
Loading

Description

This reduces systemvmtemplate size by 600MB and installs nftables,
updates iptables.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

screenshot from 2018-03-23 13-32-44
screenshot from 2018-03-23 13-33-03

How Has This Been Tested?

Manually built using packer and tested locally by running smoketests.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.

@yadvr yadvr added this to the 4.11.1.0 milestone Mar 23, 2018
@yadvr yadvr changed the title CLOUDSTACK-10341: Reduce template size, install nft CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables Mar 23, 2018
@resmo
Copy link
Copy Markdown
Member

resmo commented Mar 23, 2018 •
edited
Loading

while improving, I wonder do we already have --no-recommends? This would also skip installing docs and optimize disk space usage. I would even suggest to add it to apt.conf

cat > /etc/apt/apt.conf.d/01norecommend << EOF
APT::Install-Recommends "0";
APT::Install-Suggests "0";
EOF

Any thoughts?

resmo
resmo approved these changes Mar 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 23, 2018

Thanks @resmo, we indeed install packages with the --no-install-recommends flag https://github.com/apache/cloudstack/blob/master/tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh#L46

@yadvr yadvr mentioned this pull request Mar 23, 2018
Merged
15 tasks
@yadvr yadvr force-pushed the sysvmdisk-smaller branch from 3c0b93b to 9343e22 Compare March 23, 2018 20:24
yadvr added 5 commits March 26, 2018 23:45
@yadvr
CLOUDSTACK-10341: Reduce template size, install nft
1215ed4 
This reduces systemvmtemplate size by 600MB and installs nftables,
updates iptables.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Fix bug that fails to patch with provided release version
e8fa1cc 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Fix failure in one of the smoke tests, FAULT is not an acceptable sta…
ecece1b 
…te use UNKNOWN

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Fix failing integration test
50d14d5 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
size fixes
a7d33a7 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr force-pushed the sysvmdisk-smaller branch from 9343e22 to a7d33a7 Compare March 26, 2018 18:16
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 26, 2018

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 26, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 26, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1833

wido
wido approved these changes Mar 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

resmo
resmo approved these changes Mar 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 26, 2018

Manual tests have passed, let me kick a final run.
@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 26, 2018

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2018

Trillian test result (tid-2424)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 104750 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2424-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failure 1994.29 test_routers_network_ops.py
test_04_restart_network_wo_cleanup Failure 3.00 test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:teardown Error 0.00 test_service_offerings.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2018

Trillian test result (tid-2423)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 109583 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2423-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 6 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_restart_network_wo_cleanup Failure 4.24 test_routers.py
test_04_extract_template Failure 128.32 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_06_download_detached_volume Failure 137.94 test_volumes.py
test_04_rvpc_network_garbage_collector_nics Failure 278.52 test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance Error 3.93 test_hostha_kvm.py

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 28, 2018

Test LGTM, failures are due to environment issues or not related to this PR. Merging this based on results and two review LGTMs.

@yadvr yadvr merged commit 986ecfa into apache:4.11 Mar 28, 2018
asfgit pushed a commit that referenced this pull request Mar 28, 2018
@yadvr
[Merge 4.11] CLOUDSTACK-10341: Reduce systemvmtemplate size (#2506)
ba61b51 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2018

Trillian test result (tid-2428)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 92895 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2428-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_network.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_restart_network_wo_cleanup Failure 5.03 test_routers.py
test_09_reboot_router Error 178.95 test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:teardown Error 0.00 test_service_offerings.py

julien-vaz pushed a commit to scclouds/cloudstack that referenced this pull request Feb 18, 2025
Merge branch 'cache-mode-hypervisor-default' into '4.20.0.0-scclouds'
d524372 
Adição da opção `hypervisor default` para _cache mode_ de ofertas de disco

Closes apache#2506

See merge request scclouds/scclouds!1107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resmo resmo resmo approved these changes

@wido wido wido approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

Assignees

No one assigned

Labels

component:systemvm-template

Projects

None yet

Milestone

4.11.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @resmo @blueorangutan @wido