CLOUDSTACK-10129: Show account, network info in VR list view#2327
Conversation
|
LGTM based on the code |
|
@rhtyd I suggest to show 'Network' or 'VPC' in 'Type' field, and show the network/vpc name in 'Network' field. |
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, just UI change no need to run integration tests
|
@ustcweizhou thanks, I see your point. The router type is not something return by the API, but set by the UI limited to VPC, Project and System. I think it may be a good idea to show network/vpc/project name in another column, probably not under the 'network' column? |
This shows the owner account and network of a VR in the VR list view, and for VPCs shows the VPC name and redundant state of the VPC rVR. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
I made some more changes considering suggestions from @ustcweizhou and now, we show project names in Account tab and VPC name (with redundant router state in parenthesis) in network column: (this is not perfect but useful in knowing what VR belongs to what account/project or vpcs) |
|
Can you re-review @wido @ustcweizhou @borisstoyanov thanks. |
rafaelweingartner
left a comment
There was a problem hiding this comment.
LGTM here
@rhtyd I only have a minor remark there.
| router.guestnetworkname = router.vpcname; | ||
| } | ||
|
|
||
| if ("isredundantrouter" in router && router.isredundantrouter) { |
There was a problem hiding this comment.
I believe you can use directly router.isredundantrouter here without needing to check if the property isredundantrouter exists in the object router; undefined is interpreted as false.
There was a problem hiding this comment.
Thanks, I get defensive writing code. I guess this is not be necessary here.
|
LGTM |
This shows the owner account and network of a VR in the VR list view,
and for VPCs shows the VPC name and redundant state of the VPC rVR.
Pinging for review @PaulAngus @borisstoyanov @resmo @nvazquez @DaanHoogland @wido @ustcweizhou @rafaelweingartner and others