Skip to content

CLOUDSTACK-10123: any entity should use GMT timestamp values#2303

Merged
yadvr merged 1 commit into
apache:masterfrom
marcaurele:CLOUDSTACK-10123
Nov 18, 2017
Merged

CLOUDSTACK-10123: any entity should use GMT timestamp values#2303
yadvr merged 1 commit into
apache:masterfrom
marcaurele:CLOUDSTACK-10123

Conversation

@marcaurele
Copy link
Copy Markdown
Member

@marcaurele marcaurele commented Oct 30, 2017 •
edited
Loading

Depending on the timezone you're running CS (before GMT timezones) you could experience that some jobs are marked as failed since the parent job got a null result despite its child job having successfully done the job. The child job got deleted by the CleanupTask ahead of time, due to a missing datetime conversion to GMT timezone.

Jobs are failing with this message: Job failed with un-handled exception

The fix intends to correct any datetime used in the code that should be using the GMT timezone instead of the local one since all DB datetime should be stored at GMT.

borisstoyanov
borisstoyanov approved these changes Nov 8, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 9, 2017

LGTM, pending testing.
@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 9, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 9, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1236

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 17, 2017

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1273

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 17, 2017

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2017

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 18, 2017

Trillian test result (tid-1661)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29669 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2303-t1661-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 59 look OK, 4 have error(s)

Test Result Time (s) Test File
test_01_vpc_remote_access_vpn Failure 55.85 test_vpc_vpn.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 383.56 test_vpc_redundant.py
test_04_rvpc_privategw_static_routes Failure 243.29 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 157.77 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 172.86 test_privategw_acl.py
test_01_vpc_privategw_acl Failure 51.68 test_privategw_acl.py
test_05_add_annotation_for_invalid_entityType Error 0.08 test_host_annotations.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.00 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.01 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.02 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.08 test_primary_storage.py
test_vm_nic_adapter_vmxnet3 Skipped 0.00 test_nic_adapter_type.py
test_03_nic_multiple_vmware Skipped 1.05 test_nic.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_list_ha_for_host_valid Skipped 0.02 test_hostha_simulator.py
test_list_ha_for_host_invalid Skipped 0.02 test_hostha_simulator.py
test_list_ha_for_host Skipped 0.02 test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider Skipped 0.02 test_hostha_simulator.py
test_hostha_enable_feature_valid Skipped 0.02 test_hostha_simulator.py
test_hostha_disable_feature_valid Skipped 0.02 test_hostha_simulator.py
test_hostha_configure_invalid_provider Skipped 0.02 test_hostha_simulator.py
test_hostha_configure_default_driver Skipped 0.02 test_hostha_simulator.py
test_ha_verify_fsm_recovering Skipped 0.02 test_hostha_simulator.py
test_ha_verify_fsm_fenced Skipped 0.02 test_hostha_simulator.py
test_ha_verify_fsm_degraded Skipped 0.02 test_hostha_simulator.py
test_ha_verify_fsm_available Skipped 0.02 test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership Skipped 0.02 test_hostha_simulator.py
test_ha_list_providers Skipped 0.02 test_hostha_simulator.py
test_ha_enable_feature_invalid Skipped 0.02 test_hostha_simulator.py
test_ha_disable_feature_invalid Skipped 0.02 test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones Skipped 0.03 test_hostha_simulator.py
test_configure_ha_provider_valid Skipped 0.02 test_hostha_simulator.py
test_configure_ha_provider_invalid Skipped 0.02 test_hostha_simulator.py
test_deploy_vgpu_enabled_vm Skipped 0.03 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.03 test_deploy_vgpu_enabled_vm.py

@yadvr yadvr merged commit 421f107 into apache:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcaurele @yadvr @blueorangutan @borisstoyanov