CLOUDSTACK-10031: change default configuration for router.aggregation…#2223
Merged
Conversation
yadvr
reviewed
Aug 4, 2017
| ALTER TABLE `cloud`.`vpc` ADD COLUMN region_level_vpc boolean default false; | ||
| INSERT INTO `cloud`.`configuration`(category, instance, component, name, value, description, default_value) VALUES ('Advanced', 'DEFAULT', 'NetworkOrchestrationService', 'router.redundant.vrrp.interval', '1', 'seconds between VRRP broadcast. It would 3 times broadcast fail to trigger fail-over mechanism of redundant router', '1') ON DUPLICATE KEY UPDATE category='Advanced'; | ||
| INSERT INTO `cloud`.`configuration`(category, instance, component, name, value, description, default_value) VALUES ('Advanced', 'DEFAULT', 'NetworkOrchestrationService', 'router.aggregation.command.each.timeout', '3', 'timeout in seconds for each Virtual Router command being aggregated. The final aggregation command timeout would be determined by this timeout * commands counts ', '3') ON DUPLICATE KEY UPDATE category='Advanced'; | ||
| INSERT INTO `cloud`.`configuration`(category, instance, component, name, value, description, default_value) VALUES ('Advanced', 'DEFAULT', 'NetworkOrchestrationService', 'router.aggregation.command.each.timeout', '600', 'timeout in seconds for each Virtual Router command being aggregated. The final aggregation command timeout would be determined by this timeout * commands counts ', '600') ON DUPLICATE KEY UPDATE category='Advanced'; |
Member
There was a problem hiding this comment.
The SQL changes need to go into 410->411 upgrade sql path, where the inserts need to be modified as updates.
Contributor
Author
There was a problem hiding this comment.
Thanks, I fixed it.
d4528db to
1d6ea5e
Compare
….command.each.timeout from 3 to 600 seconds
1d6ea5e to
3cc2d31
Compare
Contributor
|
LGTM Based on the fact that this hurt me in production as well |
Member
|
LGTM. |
Member
|
Only config changes, Travis run confirms no regressions. Will merge this. |
asfgit
pushed a commit
that referenced
this pull request
Aug 17, 2017
….command.each.timeout from 3 to 600 seconds (#2223) Change default configuration for router.aggregation.command.each.timeout from 3 to 600 seconds (#2223) (cherry picked from commit 17bc6af) This fixes some test_nic failures caused due to short aggregation command timeout Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
asfgit
pushed a commit
that referenced
this pull request
Aug 17, 2017
….command.each.timeout from 3 to 600 seconds (#2223) Change default configuration for router.aggregation.command.each.timeout from 3 to 600 seconds (#2223) (cherry picked from commit 17bc6af) This fixes some test_nic failures caused due to short aggregation command timeout Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….command.each.timeout from 3 to 600 seconds
https://issues.apache.org/jira/browse/CLOUDSTACK-10031