Skip to content

CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working#2126

Merged
karuturi merged 1 commit into
masterfrom
unknown repository
Jun 6, 2017
Merged

CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working#2126
karuturi merged 1 commit into
masterfrom
unknown repository

Conversation

@niteshsarda
Copy link
Copy Markdown
Contributor

@niteshsarda niteshsarda commented May 23, 2017

Search for secondary IP of NIC that is attached to an instance is not working.

If instance has more than one secondary IP assigned and administrator attempts to search that list, all IPs are displayed instead of being filtered by the search string.
in web UI:
Dashboard -> Instances -> -> NICs -> ”View Secondary IPs” -> Search for a IP, but the search returns all the IPs in the list

Screenshot before applying fix :

screenshot before applying fix

Screenshot after applying fix :

screenshot after applying fix

@niteshsarda niteshsarda mentioned this pull request May 23, 2017
Closed
@niteshsarda
Copy link
Copy Markdown
Contributor Author

niteshsarda commented May 23, 2017

@ustcweizhou @SudharmaJain : Old PR #1909 got automatically closed while pushing updated changes to the PR. So I have created this new PR, after incorporating all the comments which both of you have provided on the old PR.

Please review this PR

@yvsubhash
Copy link
Copy Markdown

yvsubhash commented May 30, 2017

LGTM for the code

jayapalu
jayapalu reviewed May 31, 2017
View reviewed changes
Comment thread api/src/org/apache/cloudstack/api/command/user/vm/ListNicsCmd.java Outdated
resp.setObjectName("nic");
resList.add(resp);
if (this.getKeyword() != null && !this.getKeyword().isEmpty() && this.getNicId() != null) {
List<? extends NicSecondaryIp> results = _networkService.listSecondaryNics(this);
Copy link
Copy Markdown
Contributor

@jayapalu jayapalu May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the method name listSecondaryNics. Here method is not listing the secondary nics it is listing nic secondary ips. The method name some thing like listVmNicSecondaryIps

Copy link
Copy Markdown
Contributor Author

@niteshsarda niteshsarda May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayapalu : Will change the name of method as per your suggestion.

@vedulasantosh
Copy link
Copy Markdown
Contributor

vedulasantosh commented May 31, 2017

Test LGTM.
It is displaying IP's based on search string.
test_lgtm-2126
test_lgtm-2126-2

@niteshsarda
Copy link
Copy Markdown
Contributor Author

niteshsarda commented May 31, 2017

tag:This is Ready to Merge

@karuturi
Copy link
Copy Markdown
Member

karuturi commented Jun 5, 2017

@niteshsarda BVT results are required

@niteshsarda
Copy link
Copy Markdown
Contributor Author

niteshsarda commented Jun 6, 2017

tag:This is Ready to Merge
@karuturi : Test Cases which are failing are not related to my change. So can you please merge this code ?

@karuturi
Copy link
Copy Markdown
Member

karuturi commented Jun 6, 2017

@niteshsarda There are too many failed tests. Can you run again to confirm it's not a real failure?

@cloudmonger
Copy link
Copy Markdown

cloudmonger commented Jun 6, 2017

ACS CI BVT Run

Sumarry:
Build Number 801
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=2
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_non_contigiousvlan.py

  • test_extendPhysicalNetworkVlan Failed

  • test_volumes.py

  • test_06_download_detached_volume Failing since 4 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

@niteshsarda
Copy link
Copy Markdown
Contributor Author

niteshsarda commented Jun 6, 2017 •
edited
Loading

@karuturi : 2 Test Cases which are failing are not related to my change. So can you please merge this code ?
Prior 4 test cases were failing. Failure of test cases is not consistent.

@karuturi karuturi merged commit 9fd0965 into apache:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayapalu jayapalu jayapalu left review comments

Assignees

No one assigned

Labels

status:needs-CI type:bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@niteshsarda @yvsubhash @vedulasantosh @karuturi @cloudmonger @jayapalu @kiwiflyer