Escalations#184
Closed
shwetaag wants to merge 2 commits into
Closed
Conversation
|
cloudstack-pull-requests #30 SUCCESS |
Contributor
|
Looks good. I am taking this patch. |
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
Fixes #184 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Pearl1594
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Sep 6, 2022
* Add usermode interfaces to LibvirtVMDef Signed-off-by: Marcus Sorensen <marcus_sorensen@apple.com> * Update plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> * trailingwhitespace * Set model on usermode network, fix NPE in network rate Signed-off-by: Marcus Sorensen <marcus_sorensen@apple.com> Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> Co-authored-by: Daan Hoogland <daan@onecht.net> Co-authored-by: Marcus Sorensen <mls@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incorporated review comments