CLOUDSTACK-9552: Allow egress TCP/53 implicitly in Basic Networking - #1713
Merged
Conversation
Member
|
lgtm |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-65 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-112 |
Contributor
|
@wido this fix seems like a great thing for LTS. Would it be possible for you to change the base branch to 4.9? Also, would it be possible to either add or update a Marvin test case to verify this change? |
Allow DNS queries over TCP when egress filtering is configured. When using DNSSEC more and more queries are done over TCP and this requires 53/TCP to be allowed. Signed-off-by: Wido den Hollander <wido@widodh.nl>
Contributor
Author
|
@jburwell I rebased it against 4.9, checks are running now. Regarding Marvin, I have to be honest, I wouldn't know where to start for adding such a test. Do we also have Basic Networking tests at all to test stuff like this? |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-123 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-264)
|
Contributor
Author
|
LGTMs on this one? Small fix, but would be good for a LTS. |
Contributor
|
LGTM |
Member
|
LGTM. Merging this based on code review and test results. |
asfgit
pushed a commit
that referenced
this pull request
Nov 8, 2016
CLOUDSTACK-9552: Allow egress TCP/53 implicitly in Basic NetworkingAllow DNS queries over TCP when egress filtering is configured. When using DNSSEC more and more queries are done over TCP and this requires 53/TCP to be allowed. Signed-off-by: Wido den Hollander wido@widodh.nl * pr/1713: CLOUDSTACK-9552: Allow egress TCP/53 implicitly in Basic Networking Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
lucas-a-martins
pushed a commit
to scclouds/cloudstack
that referenced
this pull request
Jan 29, 2024
Filtrar volumes na UI pelo estado _Migrating_ Closes apache#1713 See merge request scclouds/scclouds!693
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow DNS queries over TCP when egress filtering is configured.
When using DNSSEC more and more queries are done over TCP and this
requires 53/TCP to be allowed.
Signed-off-by: Wido den Hollander wido@widodh.nl