[CLOUDSTACK-9337]Enhance vcenter.py to create data center in vcenter server automatically#1464
Conversation
… server automatically (Programmatically)
| folder = self.service_instance.content.rootFolder | ||
|
|
||
| if folder is not None and isinstance(folder, vim.Folder): | ||
| dc_moref = folder.CreateDatacenter(name=dcname) |
There was a problem hiding this comment.
Hello @sanju1010
Is it necessary to double check if folder is not None here? Also you mentioned some restrictions for the dcname, shouldnt they also raise and ValueError?
There was a problem hiding this comment.
@alexandrelimassantana , CreateDatacenter will through appropriate exception if the dcname is not proper. Double check for folder is to make sure that we get the rootFolder object if folder is None.
There was a problem hiding this comment.
got it. The code looks good, those were the only doubts I had. I would just use a Semaphore in line 317, but sleep an pool is not that bad also.
The code seems fine, but tests are needed.
|
Did a code walk through . LGTM . |
|
I don't have the ability to test vcenter. Is there anyone else who has the ability to test vcenter who can post the test results of a CI run? |
|
These changes will not have any impact on cloudstack code since it is purely to orchestrate the vcenter Server to create datacenter->cluster->hosts. Can we merge this without waiting for CI to run? |
|
@shwetaag @swill As I understand from @sanju1010 comment, the script is used to automate creation of dc, cluster and hosts in vCenter. The setup created can then be used to run Cloudstack tests for VMware. I don't see the need to run CI on this. |
|
I am fine with not running CI on this one. It would be nice if someone could post a screenshot or something to show that the code behaves as expected. We are missing 1 LGTM, otherwise I think we are in pretty good shape. |
|
@sanju1010 how can we test this tag:vmware-pickup |
|
anyone able to pick this up for validation and giving me a final code review??? |
|
This one is pretty much ready, but without verification that it works and without the required code reviews I can't really justify merging it. I just don't know if works and does not break anything... Not sure what to do with this one... 4.9 freeze is VERY close right now, so time is of the essence... |
|
@sanju1010 I don't know what to do with this one. I don't have any verification that this PR works, so I am not sure what information I am supposed to be going on to be confident in merging it. |
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 Failed tests: Skipped tests: Passed test suits: |
|
@swill , BVT results are clean. Can we push this to master? This will not have any impact on acs master stablity. |
|
Master is frozen in prep for the 4.9 release. This will have to wait for 4.10. |
|
👍 merging this now. |
[CLOUDSTACK-9337]Enhance vcenter.py to create data center in vcenter server automaticallyThese changes have been made to support vmware deployments in CI. For CI to create cloudstack setup with vmware, it is required to create datacenter, cluster and hosts in vcenter server before adding in cloudstack. Added few methods in vcenter.py to perform these tasks. Please refer to CLOUDSTACK-9337 for more details. * pr/1464: [CLOUDSTACK-9337]Enhance vcenter.py to created data center in vcenter server automatically (Programmatically) Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
Corrigir descrição da API `moveUser` e de seus parâmetros Closes apache#1464 See merge request scclouds/scclouds!725
These changes have been made to support vmware deployments in CI.
For CI to create cloudstack setup with vmware, it is required to create datacenter, cluster and hosts in vcenter server before adding in cloudstack. Added few methods in vcenter.py to perform these tasks.
Please refer to CLOUDSTACK-9337 for more details.