Skip to content

Revert "security groups: conntrack only if needed (#10594)" - #14443

Open
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:24-revert-10594
Open

Revert "security groups: conntrack only if needed (#10594)"#14443
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:24-revert-10594

Conversation

@weizhouapache

@weizhouapache weizhouapache commented Oct 20, 2026

Copy link
Copy Markdown
Member

Description

This reverts commit bb5da0e.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI balanced review requested due to automatic review settings October 20, 2026 06:18
@boring-cyborg boring-cyborg Bot added component:networking Python Warning... Python code Ahead! labels Oct 20, 2026
Copilot AI reviewed Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@weizhouapache

weizhouapache commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

This reverts #10594 which caused #14099 #14432 in ACS 4.23.0 and current upstream.

The script file is critical for public cloud providers, the script before #10594 has been proved to be working for several years. To reduce the impact, it would be better to revert the changes.

cc @wido

@weizhouapache weizhouapache linked an issue Oct 20, 2026 that may be closed by this pull request
VMs with security groups allowing all egress traffic cannot access the Internet in 4.23.0.0 #14099
Open
@weizhouapache weizhouapache mentioned this pull request Oct 20, 2026
Closed
1 of 14 tasks
@weizhouapache weizhouapache linked an issue Oct 20, 2026 that may be closed by this pull request
KVM security groups: ingress rules are bypassed for traffic between VMs on the same host (regression from #10594) #14432
Open
@weizhouapache weizhouapache mentioned this pull request Oct 20, 2026
Open
@weizhouapache weizhouapache added this to the 24.0 milestone Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.45%. Comparing base (af9764b) to head (fe1520f).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #14443   +/-   ##
=========================================
  Coverage     20.45%   20.45%           
- Complexity    21415    21416    +1     
=========================================
  Files          6487     6487           
  Lines        589303   589303           
  Branches      72245    72245           
=========================================
+ Hits         120525   120536   +11     
+ Misses       455643   455632   -11     
  Partials      13135    13135
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 21.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

component:networking component:security-group Python Warning... Python code Ahead! Severity:Critical Critical bug

Projects

None yet

Milestone

24.0

2 participants

@weizhouapache