Skip to content

oauth: api: add missing version since - #13890

Open
resmo wants to merge 1 commit into
apache:mainfrom
resmo:fix/missing-api-version
Open

oauth: api: add missing version since#13890
resmo wants to merge 1 commit into
apache:mainfrom
resmo:fix/missing-api-version

Conversation

@resmo

@resmo resmo commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

follow up of PR #13033

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI lite review requested due to automatic review settings August 16, 2026 09:39
@resmo
resmo marked this pull request as ready for review August 16, 2026 09:39
Copilot AI reviewed Aug 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a small follow-up to the Keycloak OAuth provider work (PR #13033) that fixes API metadata by adding missing since = "4.23.0" versioning on newly introduced OAuth provider parameters, improving generated API documentation and version-awareness for clients.

Changes:

  • Add since = "4.23.0" to authorizeUrl and tokenUrl parameters in registerOAuthProvider.
  • Add since = "4.23.0" to authorizeUrl and tokenUrl parameters in updateOAuthProvider.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/UpdateOAuthProviderCmd.java Adds missing API since metadata to the new OAuth provider URL parameters on update.
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/RegisterOAuthProviderCmd.java Adds missing API since metadata to the new OAuth provider URL parameters on register.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.65%. Comparing base (1cd2491) to head (2934f73).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #13890   +/-   ##
=========================================
  Coverage     19.65%   19.65%           
- Complexity    19794    19795    +1     
=========================================
  Files          6368     6368           
  Lines        574889   574889           
  Branches      70353    70353           
=========================================
  Hits         112985   112985           
+ Misses       449634   449633    -1     
- Partials      12270    12271    +1
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@resmo resmo added this to the 4.23.0 milestone Aug 16, 2026
@DaanHoogland

DaanHoogland commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

heads-up @winterhazel @weizhouapache , should this go in rc3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@resmo @DaanHoogland