Skip to content

config cleanup - #13884

Draft
DaanHoogland wants to merge 13 commits into
mainfrom
ghi10752-configCleanup
Draft

config cleanup#13884
DaanHoogland wants to merge 13 commits into
mainfrom
ghi10752-configCleanup

move virtual router configuration items from deprecated Config enum t…

2a6c35b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Aug 15, 2026 in 6m 49s

Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 40%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 50 in server/src/main/java/com/cloud/server/ManagementServer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Specify the private bridge on host for private network" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWBdqJXQQ7HDE9SA&open=AaAFdWBdqJXQQ7HDE9SA&pullRequest=13884

Check failure on line 25 in server/src/main/java/com/cloud/projects/ProjectManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWJnqJXQQ7HDE9SK&open=AaAFdWJnqJXQQ7HDE9SK&pullRequest=13884

Check failure on line 38 in engine/components-api/src/main/java/com/cloud/network/security/SecurityGroupManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Network" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVstqJXQQ7HDE9R2&open=AaAFdVstqJXQQ7HDE9R2&pullRequest=13884

Check failure on line 94 in api/src/main/java/com/cloud/network/NetworkService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Hidden" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVvZqJXQQ7HDE9R6&open=AaAFdVvZqJXQQ7HDE9R6&pullRequest=13884

Check warning on line 880 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAGbHxQTV2yRQvmzXM1&open=AaAGbHxQTV2yRQvmzXM1&pullRequest=13884

Check warning on line 1449 in engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this condition so that it does not always evaluate to "false" 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVkmqJXQQ7HDE9R0&open=AaAFdVkmqJXQQ7HDE9R0&pullRequest=13884

Check failure on line 30 in api/src/main/java/org/apache/cloudstack/usage/UsageService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Usage" 6 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVtkqJXQQ7HDE9R3&open=AaAFdVtkqJXQQ7HDE9R3&pullRequest=13884

Check warning on line 149 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_publicIPCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SH&open=AaAFdWG4qJXQQ7HDE9SH&pullRequest=13884

Check failure on line 64 in api/src/main/java/com/cloud/storage/VolumeApiService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Storage" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVuAqJXQQ7HDE9R4&open=AaAFdVuAqJXQQ7HDE9R4&pullRequest=13884

Check failure on line 82 in server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdV8EqJXQQ7HDE9R-&open=AaAFdV8EqJXQQ7HDE9R-&pullRequest=13884

Check warning on line 1554 in server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAGbHtbTV2yRQvmzXM0&open=AaAGbHtbTV2yRQvmzXM0&pullRequest=13884

Check failure on line 39 in api/src/main/java/com/cloud/user/ResourceLimitService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Project Defaults" 12 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVv5qJXQQ7HDE9R8&open=AaAFdVv5qJXQQ7HDE9R8&pullRequest=13884

Check failure on line 53 in server/src/main/java/com/cloud/storage/secondary/SecondaryStorageVmManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAGbHJzTV2yRQvmzXMx&open=AaAGbHJzTV2yRQvmzXMx&pullRequest=13884

Check failure on line 34 in server/src/main/java/com/cloud/projects/ProjectManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Project Defaults" 7 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWJnqJXQQ7HDE9SL&open=AaAFdWJnqJXQQ7HDE9SL&pullRequest=13884

Check warning on line 150 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_privateIPCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SG&open=AaAFdWG4qJXQQ7HDE9SG&pullRequest=13884

Check failure on line 25 in engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StorageCacheManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Storage" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVpfqJXQQ7HDE9R1&open=AaAFdVpfqJXQQ7HDE9R1&pullRequest=13884

Check failure on line 52 in api/src/main/java/com/cloud/user/ResourceLimitService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Domain Defaults" 13 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVv5qJXQQ7HDE9R7&open=AaAFdVv5qJXQQ7HDE9R7&pullRequest=13884

Check failure on line 46 in server/src/main/java/com/cloud/configuration/Config.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Alert" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWPKqJXQQ7HDE9SO&open=AaAFdWPKqJXQQ7HDE9SO&pullRequest=13884

Check warning on line 153 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_directNetworkPublicIpCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SE&open=AaAFdWG4qJXQQ7HDE9SE&pullRequest=13884

Check failure on line 44 in server/src/main/java/com/cloud/server/ManagementServer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Hidden" 10 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWBdqJXQQ7HDE9R_&open=AaAFdWBdqJXQQ7HDE9R_&pullRequest=13884

Check warning on line 882 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAGbHxQTV2yRQvmzXM2&open=AaAGbHxQTV2yRQvmzXM2&pullRequest=13884

Check failure on line 831 in server/src/main/java/com/cloud/configuration/Config.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWPKqJXQQ7HDE9SQ&open=AaAFdWPKqJXQQ7HDE9SQ&pullRequest=13884

Check failure on line 183 in server/src/main/java/com/cloud/server/ConfigurationServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAGbHevTV2yRQvmzXMz&open=AaAGbHevTV2yRQvmzXMz&pullRequest=13884

Check warning on line 152 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_vlanCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SJ&open=AaAFdWG4qJXQQ7HDE9SJ&pullRequest=13884

Check warning on line 151 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_secondaryStorageCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SI&open=AaAFdWG4qJXQQ7HDE9SI&pullRequest=13884
View more details on SonarQubeCloud