Skip to content

Fix KBOSS backup creation edge case #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoaoJandre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix KBOSS backup creation edge case #13880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/backup/kboss/src/main/java/org/apache/cloudstack/backup/KbossBackupProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,8 +1819,8 @@ protected DeltaMergeTreeTO createDeltaMergeTree(boolean childIsVolume, boolean r
succeedingDeltaPaths = gatherSnapshotReferencesOfChildrenSnapshot(List.of(volumeObjectTO), succeedingVmSnapshot).getOrDefault(volumeObjectTO.getVolumeId(), List.of())
.stream().map(SnapshotDataStoreVO::getInstallPath).collect(Collectors.toList());

if (!childIsVolume && !runningVm && succeedingDeltaPaths.isEmpty()) {
succeedingDeltaPaths = List.of(volumeObjectTO.getPath());
if (!childIsVolume && !runningVm && succeedingVmSnapshot.getCurrent()) {
succeedingDeltaPaths.add(volumeObjectTO.getPath());
logger.debug("Since the last backup delta of volume [{}] is succeeded by a snapshot and the delta created by this snapshot is also the volume, it will have to be" +
" rebased. Setting it as the grand-child.", volumeObjectTO.getUuid());
}
Expand Down
Loading