Skip to content

markdown table format fixes - #13848

Merged
jbampton merged 2 commits into
mainfrom
markdown-fixes
Aug 11, 2026
Merged

markdown table format fixes#13848
jbampton merged 2 commits into
mainfrom
markdown-fixes

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR… follows on #12943 after the extra markdown lint rule came into effect.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI lite review requested due to automatic review settings August 11, 2026 12:28
@DaanHoogland DaanHoogland changed the title markdaown table format fixes markdown table format fixes Aug 11, 2026
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (ebc5e64) to head (bc1677d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13848      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
  Complexity    19790    19790              
============================================
  Files          6368     6368              
  Lines        574889   574889              
  Branches      70353    70353              
============================================
- Hits         112966   112963       -3     
- Misses       449649   449655       +6     
+ Partials      12274    12271       -3     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings August 11, 2026 13:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

plugins/storage/volume/ontap/README.md:41

  • These tables use a double leading pipe (||), which in standard GitHub/CommonMark table parsing renders as an extra empty first column. If the intent is a 2-column table, switch rows to a single leading pipe (| Package | Description |) throughout the table (and similarly for the other tables in this README) so the rendered documentation doesn’t include a blank column.
| Package | Description |
| --- | --- |
| `driver` | Primary datastore driver implementation |

plugins/storage/volume/ontap/README.md:74

  • The PR description/template appears unfilled (no change type selected, no testing notes). Since the template explicitly notes automation relies on it, please select the appropriate change type and add a brief testing note (even if it’s just “markdownlint only”).
When creating an ONTAP primary storage pool, provide the following details in the URL field (semicolon-separated key=value pairs):

@DaanHoogland
DaanHoogland marked this pull request as ready for review August 11, 2026 13:42
@github-actions

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.50%
Branch coverage 18.67%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.50%
Branch coverage 18.67%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@jbampton jbampton self-assigned this Aug 11, 2026
@jbampton
jbampton merged commit e201213 into main Aug 11, 2026
29 checks passed
@jbampton
jbampton deleted the markdown-fixes branch August 11, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants