Change 2FA Field Type From Password to Text#13671
Open
daviftorres wants to merge 12 commits into
Open
Conversation
Pulling upstream.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CloudStack Management UI’s 2FA code inputs to use a plain text input instead of a password input, addressing password-manager behavior where OTP/static-pin fields may be treated like real password fields (Issue #13337).
Changes:
- Replaced
<a-input-password>with<a-input>for 2FA code entry in login/setup/verify flows. - Keeps existing form bindings and submission behavior while changing the rendered input type/behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ui/src/views/iam/SetupTwoFaAtUserProfile.vue | Switches the 2FA code field from password input to standard input in the user-profile 2FA setup flow. |
| ui/src/views/dashboard/VerifyTwoFa.vue | Switches the 2FA verification code field from password input to standard input in the login verification step. |
| ui/src/views/dashboard/SetupTwoFaAtLogin.vue | Switches the 2FA code field from password input to standard input in the login-time 2FA setup flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
ui/src/views/dashboard/VerifyTwoFa.vue:41
- After replacing
<a-input-password>with<a-input>, thefocusInput()method still queriesinput[type=password], so the OTP field will no longer be auto-focused on mount. Update the selector to target the new input (e.g., query forinputorinput[type=text]) or use a dedicated ref for the<a-input>element.
<a-form-item name="code" ref="code" style="text-align: center;">
<a-input
style="width: 500px"
v-model:value="form.code"
autocomplete="one-time-code"
inputmode="numeric"
placeholder="xxxxxx" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR suggest changes to #13337.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Note: I am not a developer, so please do the appropriated tests to validate what I propose. It is at the best of my intentions and limited by my competences.