add an maintenance prepare error event#13669
Open
DaanHoogland wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds a new CloudStack event type to record failures while preparing a host for maintenance, and extends unit tests to validate event emission and entity mapping.
Changes:
- Introduce
MAINT.PREPARE.ERRORevent type and map it toHostentity. - Emit an error ActionEvent when a host enters
PrepareForMaintenanceWithErrors. - Add/extend unit tests validating the emitted event and entity mapping.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| server/src/main/java/com/cloud/resource/ResourceManagerImpl.java | Emits a new error event when host preparation for maintenance fails due to VM/migration issues. |
| api/src/main/java/com/cloud/event/EventTypes.java | Adds the new maintenance prepare error event constant and maps it to Host. |
| server/src/test/java/com/cloud/resource/ResourceManagerImplTest.java | Verifies the new event is emitted and mapped to the correct entity class. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1729
to
+1731
| ActionEventUtils.onCompletedActionEvent(CallContext.current().getCallingUserId(), CallContext.current().getCallingAccountId(), | ||
| EventVO.LEVEL_ERROR, EventTypes.EVENT_MAINTENANCE_PREPARE_ERROR, | ||
| String.format("failed to prepare host %s for maintenance due to migration or VM state errors", host), host.getId(), null, 0); |
| resourceStateTransitTo(host, ResourceState.Event.UnableToMigrate, _nodeId); | ||
| ActionEventUtils.onCompletedActionEvent(CallContext.current().getCallingUserId(), CallContext.current().getCallingAccountId(), | ||
| EventVO.LEVEL_ERROR, EventTypes.EVENT_MAINTENANCE_PREPARE_ERROR, | ||
| String.format("failed to prepare host %s for maintenance due to migration or VM state errors", host), host.getId(), null, 0); |
Comment on lines
+456
to
+459
| String expectedDescription = String.format("failed to prepare host %s for maintenance due to migration or VM state errors", host); | ||
| actionEventUtilsMocked.verify(() -> ActionEventUtils.onCompletedActionEvent( | ||
| anyLong(), anyLong(), eq(EventVO.LEVEL_ERROR), eq(EventTypes.EVENT_MAINTENANCE_PREPARE_ERROR), | ||
| eq(expectedDescription), eq(hostId), isNull(), eq(0L))); |
| public static final String EVENT_MAINTENANCE_CANCEL = "MAINT.CANCEL"; | ||
| public static final String EVENT_MAINTENANCE_CANCEL_PRIMARY_STORAGE = "MAINT.CANCEL.PS"; | ||
| public static final String EVENT_MAINTENANCE_PREPARE = "MAINT.PREPARE"; | ||
| public static final String EVENT_MAINTENANCE_PREPARE_ERROR = "MAINT.PREPARE.ERROR"; |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Fixes: #13324
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?