Skip to content

Fix/nsx preserve foreign lb monitors#13575

Closed
vitaliyzahorenko wants to merge 2 commits into
apache:mainfrom
PlaytikaOSS:fix/nsx-preserve-foreign-lb-monitors
Closed

Fix/nsx preserve foreign lb monitors#13575
vitaliyzahorenko wants to merge 2 commits into
apache:mainfrom
PlaytikaOSS:fix/nsx-preserve-foreign-lb-monitors

Conversation

@vitaliyzahorenko

@vitaliyzahorenko vitaliyzahorenko commented Jul 9, 2026

Copy link
Copy Markdown

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

ZhyliaievD and others added 2 commits April 8, 2026 14:59
@ZhyliaievD
nsx patches
270a440
fix(nsx): preserve externally-created active LB monitors on pool patch
9380433 
createNsxLbServerPool() replaced LBPool.ActiveMonitorPaths entirely with a
single, app-managed monitor path whenever the pool was patched (e.g. on a
member list change). Any active monitor attached to the pool outside of
this codebase (manually, or by another process) was silently detached on
the next update.

The pool state already fetched for the member-diff check is now reused
to also merge active monitor paths: monitors whose id does not contain
the pool name are preserved, and only the app-owned monitor path is
added/refreshed.

Verified on staging NSX: a manually attached foreign monitor survives a
pool member list update.
@boring-cyborg

boring-cyborg Bot commented Jul 9, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594 Pearl1594 is a code owner
@nvazquez nvazquez Awaiting requested review from nvazquez nvazquez is a code owner

Assignees

No one assigned

Labels

component:networking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vitaliyzahorenko @ZhyliaievD