Skip to content

ConfigureStorageAccessCmd: Allow storage access configuration on empty clusters/pods/zones#13551

Open
nvazquez wants to merge 1 commit into
apache:4.22from
shapeblue:422-cfg-storage-access-empty-resources
Open

ConfigureStorageAccessCmd: Allow storage access configuration on empty clusters/pods/zones#13551
nvazquez wants to merge 1 commit into
apache:4.22from
shapeblue:422-cfg-storage-access-empty-resources

Conversation

@nvazquez

@nvazquez nvazquez commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

This PR has the fix for the below issue:

cmk configure storageaccess operation throws an exception when zone/cluster/pod referenced in the operation is empty.

Exception: com.cloud.utils.exception.CloudRuntimeException: All hosts in the cluster are using the storage access groups

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

apache#578)

* ConfigureStorageAccessCmd: Allow storage access configuration on empty clusters/pods/zones

* update as per comments

Co-authored-by: mprokopchuk <mprokopchuk@gmail.com>

* update as per review comments

Co-authored-by: mprokopchuk <mprokopchuk@gmail.com>

* update as per comments

Co-authored-by: mprokopchuk <mprokopchuk@gmail.com>

---------

Co-authored-by: Sachin R Doddaguni <s_rudrappadoddagu@apple.com>
Co-authored-by: mprokopchuk <mprokopchuk@gmail.com>
(cherry picked from commit 32736b9e262522912cf8755acabfb7400006252f)
@nvazquez

nvazquez commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (4262c02) to head (aca4088).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13551      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
- Complexity    15796    15803       +7     
============================================
  Files          5923     5923              
  Lines        533347   533347              
  Branches      65248    65254       +6     
============================================
- Hits          94253    94251       -2     
- Misses       428435   428436       +1     
- Partials      10659    10660       +1     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants