Fix findHostsForMigration never returning hosts from other clusters#13452
Open
winterhazel wants to merge 1 commit into
Open
Fix findHostsForMigration never returning hosts from other clusters#13452winterhazel wants to merge 1 commit into
findHostsForMigration never returning hosts from other clusters#13452winterhazel wants to merge 1 commit into
Conversation
Member
Author
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
cffdf71 to
f6c603b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13452 +/- ##
=========================================
Coverage 16.25% 16.26%
- Complexity 13432 13439 +7
=========================================
Files 5667 5667
Lines 500670 500687 +17
Branches 60801 60803 +2
=========================================
+ Hits 81397 81438 +41
+ Misses 410165 410142 -23
+ Partials 9108 9107 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced in #12014. Before 4.20.3, if the instance supported storage migration, the API would create a deployment plan passing the
clusterIdas null to also list compatible hosts from other clusters. In 4.20.3, aclusterIdis always provided to the plan. Due to this, hosts from other clusters are never returned.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested by opening the migration wizard for a running instance and validating that hosts from other clusters were returned as compatible.