Skip to content

nasbackup: improve error reporting during backup#13426

Draft
shwstppr wants to merge 1 commit into
apache:4.22from
shapeblue:nasbackup-prevent-unknownerr
Draft

nasbackup: improve error reporting during backup#13426
shwstppr wants to merge 1 commit into
apache:4.22from
shapeblue:nasbackup-prevent-unknownerr

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

If any failure after backup job return the error and not just the backup job info, destination size.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

If any failure after backup job return the error and not just the backup
job info, destination size.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr force-pushed the nasbackup-prevent-unknownerr branch from c3f09b0 to 49af7e6 Compare June 15, 2026 21:07
@shwstppr shwstppr changed the title nasbackup: improve nasbackup error reporting during backup nasbackup: improve error reporting during backup Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (8e933b7) to head (49af7e6).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13426      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
+ Complexity    15792    15789       -3     
============================================
  Files          5922     5922              
  Lines        533167   533167              
  Branches      65210    65210              
============================================
- Hits          94246    94234      -12     
- Misses       428276   428287      +11     
- Partials      10645    10646       +1     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant