Skip to content

Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProjectMoon wants to merge 1 commit into from
Closed

Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/lib/cloudutils/serviceConfigServer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,8 @@ def checkHostName():
except:
pass

self.syscfg.svo.stopService("cloudstack-management")

if self.syscfg.env.noStart == False:
self.syscfg.svo.stopService("cloudstack-management")

@DaanHoogland DaanHoogland Jan 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if nostart is false (start is true ??) the service is stopped. Am I understanding this wrong? it seems like we don't want this here and not unconditionally either but only if nostart is true.

@ProjectMoon ProjectMoon Jan 12, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the original behavior of the script, before --no-start was added. When --no-start is NOT specified, the script tries to make sure that the service is stopped before starting it again.

if self.syscfg.svo.enableService("cloudstack-management"):
return True
else:
Expand Down