Skip to content

fix label key for gpudisplay#13272

Open
sudo87 wants to merge 1 commit into
apache:mainfrom
shapeblue:fixGpuLabel
Open

fix label key for gpudisplay#13272
sudo87 wants to merge 1 commit into
apache:mainfrom
shapeblue:fixGpuLabel

Conversation

@sudo87
Copy link
Copy Markdown
Contributor

@sudo87 sudo87 commented May 28, 2026

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2026-05-28 at 3 26 11 PM

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 requested a review from vishesh92 May 28, 2026 09:58
@vishesh92
Copy link
Copy Markdown
Member

vishesh92 commented May 28, 2026

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 28, 2026

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

vishesh92
vishesh92 approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.11%. Comparing base (c0ce5b4) to head (f4cdd27).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #13272   +/-   ##
=========================================
  Coverage     18.10%   18.11%           
- Complexity    16749    16758    +9     
=========================================
  Files          6037     6037           
  Lines        542796   542796           
  Branches      66456    66456           
=========================================
+ Hits          98268    98320   +52     
+ Misses       433492   433430   -62     
- Partials      11036    11046   +10
Flag Coverage Δ
uitests 3.51% <ø> (ø)
unittests 19.27% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 28, 2026

I fail to see how this is an improvement. I would argue other lebals need an extra . after gpu...

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 28, 2026

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13272 (QA-JID-943)

@sudo87
Copy link
Copy Markdown
Contributor Author

sudo87 commented May 28, 2026

I fail to see how this is an improvement. I would argue other lebals need an extra . after gpu...

label.gpudisplay is currently used in the offering details and is defined here:

cloudstack/ui/src/config/section/offering.js

Line 44 in c0ce5b4

var fields = ['name', 'id', 'displaytext', 'offerha', 'provisioningtype', 'storagetype', 'iscustomized', 'iscustomizediops', 'limitcpuuse', 'cpunumber', 'cpuspeed', 'memory', 'hosttags', 'tags', 'storageaccessgroups', 'storagetags', 'domain', 'zone', 'created', 'dynamicscalingenabled', 'diskofferingstrictness', 'encryptroot', 'purgeresources', 'leaseduration', 'gpucardid', 'gpucardname', 'vgpuprofileid', 'vgpuprofilename', 'gpucount', 'gpudisplay', 'leaseexpiryaction', 'externaldetails']

We need to define 'label.gpudisplay' to render the label value. I avoided duplicating the key 'label.gpu.display' and renamed it to label.gpudisplay to keep it single-sourced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishesh92 vishesh92 vishesh92 approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sudo87 @vishesh92 @blueorangutan @DaanHoogland @bernardodemarco