Skip to content

Remove the duplicate configkey json.content.type#13264

Open
sureshanaparti wants to merge 1 commit into
apache:4.20from
shapeblue:remove-duplicate-configkey-json.content.type
Open

Remove the duplicate configkey json.content.type#13264
sureshanaparti wants to merge 1 commit into
apache:4.20from
shapeblue:remove-duplicate-configkey-json.content.type

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented May 27, 2026 •
edited
Loading

Description

This PR removes the duplicate configkey json.content.type. Preserved the same description for the config as now in the CloudStack deployment.

The config key was added twice here: https://github.com/apache/cloudstack/pull/2848/files#diff-d4f381fc49d5bb07c76daf73677484cace911ff56eb08e60b253b6ef0273124d (in 4.12.0.0) and one config key is unused.

mysql> SELECT * FROM cloud.configuration WHERE name = 'json.content.type'\G;
*************************** 1. row ***************************
     category: Advanced
     instance: DEFAULT
    component: ApiServer
         name: json.content.type
        value: application/json; charset=UTF-8
  description: Http response content type for JSON
default_value: application/json; charset=UTF-8
      updated: 2026-05-06 15:55:35
   is_dynamic: 0
     group_id: 1
  subgroup_id: 1
       parent: NULL
 display_text: Json content type
         kind: NULL
      options: NULL
        scope: 1
1 row in set (0.01 sec)

mysql> SELECT * FROM cloud.configuration WHERE description LIKE '%Http response content%'\G;
*************************** 1. row ***************************
     category: Advanced
     instance: DEFAULT
    component: ApiServer
         name: json.content.type
        value: application/json; charset=UTF-8
  description: Http response content type for JSON
default_value: application/json; charset=UTF-8
      updated: 2026-05-06 15:55:35
   is_dynamic: 0
     group_id: 1
  subgroup_id: 1
       parent: NULL
 display_text: Json content type
         kind: NULL
      options: NULL
        scope: 1
1 row in set (0.01 sec)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.20.4 milestone May 27, 2026
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented May 27, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 27, 2026

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (c267ad3) to head (2cd1368).
⚠️ Report is 3 commits behind head on 4.20.

Files with missing lines Patch % Lines
server/src/main/java/com/cloud/api/ApiServlet.java 40.00% 5 Missing and 1 partial ⚠️
server/src/main/java/com/cloud/api/ApiServer.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #13264      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
+ Complexity    13433    13432       -1     
============================================
  Files          5665     5666       +1     
  Lines        500572   500626      +54     
  Branches      60792    60796       +4     
============================================
+ Hits          81417    81425       +8     
- Misses       410047   410092      +45     
- Partials       9108     9109       +1
Flag Coverage Δ
uitests 4.14% <ø> (-0.01%) ⬇️
unittests 17.12% <41.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 27, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18061

DaanHoogland
DaanHoogland approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

3 participants

@sureshanaparti @blueorangutan @DaanHoogland