Fix Prometheus exporter not recognizing ::1 as IPv6 loopback#13245
Open
DaanHoogland wants to merge 1 commit into
Open
Fix Prometheus exporter not recognizing ::1 as IPv6 loopback#13245DaanHoogland wants to merge 1 commit into
DaanHoogland wants to merge 1 commit into
Conversation
Normalize IPv6 addresses using InetAddress.getHostAddress() so that compressed forms like ::1 and full forms like 0:0:0:0:0:0:0:1 are treated as equivalent when checking the allowed IPs list. Fixes #6714
Contributor
Author
|
@Rubueno , you care to test this? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13245 +/- ##
============================================
- Coverage 18.10% 18.10% -0.01%
+ Complexity 16749 16748 -1
============================================
Files 6037 6037
Lines 542957 542965 +8
Branches 66487 66487
============================================
Hits 98290 98290
- Misses 433619 433627 +8
Partials 11048 11048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
I don't have a test env available right now, but reducing the change to a very minimal compiled program seems to render the expected output Thanks Daan! |
Contributor
Author
|
@blueeorangutan package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize IPv6 addresses using InetAddress.getHostAddress() so that compressed forms like ::1 and full forms like 0:0:0:0:0:0:0:1 are treated as equivalent when checking the allowed IPs list.
Fixes #6714
(claude assisted fix)
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?