Skip to content

Don't allow assign VM to backup offering for VM with encrypted volumes #13229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sureshanaparti wants to merge 1 commit into
base: 4.22
Choose a base branch
from
+36 −0
Open

Don't allow assign VM to backup offering for VM with encrypted volumes #13229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,13 @@ public boolean assignVMToBackupOffering(Long vmId, Long offeringId) {
throw new CloudRuntimeException("VM is not in running or stopped state");
}

List<VolumeVO> volumes = volumeDao.findByInstance(vmId);
for (VolumeVO volume : volumes) {
if (volume != null && volume.getPassphraseId() != null) {
throw new CloudRuntimeException("VM has encrypted volumes, backup offering assignment is not allowed");
}
}

validateBackupForZone(vm.getDataCenterId());

accountManager.checkAccess(CallContext.current().getCallingAccount(), null, true, vm);
Expand Down
29 changes: 29 additions & 0 deletions server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,14 @@ public void testAssignVMToBackupOffering() {
when(vm.getDataCenterId()).thenReturn(1L);
when(vm.getBackupOfferingId()).thenReturn(null);
when(offering.getProvider()).thenReturn("testbackupprovider");
VolumeVO volume = mock(VolumeVO.class);
when(volumeDao.findByInstance(vmId)).thenReturn(List.of(volume));
when(volume.getPassphraseId()).thenReturn(null);
Long diskOfferingId = 5L;
when(volume.getDiskOfferingId()).thenReturn(diskOfferingId);
DiskOfferingVO diskOffering = Mockito.mock(DiskOfferingVO.class);
Mockito.when(diskOffering.getUuid()).thenReturn("disk-offering-uuid");
Mockito.when(diskOfferingDao.findById(diskOfferingId)).thenReturn(diskOffering);
when(backupProvider.assignVMToBackupOffering(vm, offering)).thenReturn(true);
when(vmInstanceDao.update(1L, vm)).thenReturn(true);

Expand All @@ -1225,11 +1233,32 @@ public void testAssignVMToBackupOffering() {

assertTrue(result);
verify(vmInstanceDao, times(1)).findById(vmId);
verify(volumeDao, times(2)).findByInstance(vmId);
verify(backupOfferingDao, times(1)).findById(offeringId);
verify(backupManager, times(1)).getBackupProvider("testbackupprovider");
}
}

@Test (expected = CloudRuntimeException.class)
public void testAssignVMToBackupOfferingForVMWithEncryptedVolumes() {
Long vmId = 1L;
Long offeringId = 2L;

VMInstanceVO vm = mock(VMInstanceVO.class);
overrideBackupFrameworkConfigValue();

when(vmInstanceDao.findById(vmId)).thenReturn(vm);
when(vm.getState()).thenReturn(VirtualMachine.State.Running);
VolumeVO volume = mock(VolumeVO.class);
when(volumeDao.findByInstance(vmId)).thenReturn(List.of(volume));
when(volume.getPassphraseId()).thenReturn(42L);

try (MockedStatic<UsageEventUtils> ignored2 = Mockito.mockStatic(UsageEventUtils.class)) {
backupManager.assignVMToBackupOffering(vmId, offeringId);
verify(vmInstanceDao, times(1)).findById(vmId);
}
}

@Test
public void testRemoveVMFromBackupOffering() {
Long vmId = 1L;
Expand Down
Loading