add VR health checks to prometheus output#13218
Open
DaanHoogland wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Prometheus exporter plugin to expose Virtual Router health-check results via the /metrics endpoint, addressing the need to monitor VR health checks without per-router API polling (Fixes #6212).
Changes:
- Collect router health-check results from
router_health_checkand export per-check status ascloudstack_virtualrouter_healthcheck_result. - Export the last update time (Unix epoch seconds) per check as
cloudstack_virtualrouter_healthcheck_lastcheck. - Wire in the required DAOs (
DomainRouterDao,RouterHealthCheckResultDao) and add new metric item types.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+520
to
+524
| if (router.getRole() != VirtualRouter.Role.VIRTUAL_ROUTER) { | ||
| continue; | ||
| } | ||
| List<RouterHealthCheckResultVO> checks = routerHealthCheckResultDao.getHealthCheckResults(router.getId()); | ||
| if (checks == null || checks.isEmpty()) { |
Comment on lines
+519
to
+523
| for (DomainRouterVO router : routers) { | ||
| if (router.getRole() != VirtualRouter.Role.VIRTUAL_ROUTER) { | ||
| continue; | ||
| } | ||
| List<RouterHealthCheckResultVO> checks = routerHealthCheckResultDao.getHealthCheckResults(router.getId()); |
Comment on lines
+514
to
+518
| private void addVirtualRouterHealthCheckMetrics(final List<Item> metricsList, final long dcId, final String zoneName, final String zoneUuid) { | ||
| List<DomainRouterVO> routers = domainRouterDao.listByDataCenter(dcId); | ||
| if (routers == null) { | ||
| return; | ||
| } |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13218 +/- ##
============================================
- Coverage 18.09% 18.09% -0.01%
- Complexity 16732 16733 +1
============================================
Files 6037 6037
Lines 542811 542862 +51
Branches 66471 66479 +8
============================================
+ Hits 98230 98233 +3
- Misses 433533 433581 +48
Partials 11048 11048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Fixes: #6212
aided by AI
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?