Convert command's timeout for snapshots commands#13210
Open
erikbocks wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13210 +/- ##
============================================
- Coverage 18.09% 18.09% -0.01%
- Complexity 16732 16733 +1
============================================
Files 6037 6037
Lines 542780 542812 +32
Branches 66464 66471 +7
============================================
Hits 98233 98233
- Misses 433499 433531 +32
Partials 11048 11048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The #9659 PR introduced the
commands.timeoutglobal configuration for granular command timeout definition. If a operator wishes to increase snapshot related timeouts, he could increase theCreateObjectCommandtimeout in thecommands.timeoutconfiguration. The defined timeouts are set in seconds.However, normal and incremental snapshots creation flows use
qemu-imgscript to execute some of the necessary operations. These scripts accept timeouts as milliseconds, but receive them as seconds from theCreateObjectCommand. This leads to incorrect timeouts.Therefore, this PR converts the
CreateObjectCommandseconds to milliseconds before passing them toqemu-imgscripts.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
First, I set
commands.timeoutconfiguration value toCreateObjectCommand=300. This defines this command timeout to 5 minutes. Then, I tried to create a full volume snapshot. The process failed due to a timeout.Command timeout log
Failure log
I installed the packages with the timeout conversion to my local environment, then tried to create another snapshot. Using a debug breakpoint, I validated that the
qemu-imgscript instance had the converted timeout. The new snapshot was created successfully,When trying to create a incremental snapshot, the same error occurred. Then, I installed the packages with the necessary changes and tried to create another incremental snapshot. This process also used debug breakpoints to validate the scripts timeout.