Skip to content

Root CA: support multiple management network CIDRs with comma separated#13206

Draft
weizhouapache wants to merge 2 commits into
apache:4.22from
weizhouapache:4.22-root-ca-multiple-network-cidrs
Draft

Root CA: support multiple management network CIDRs with comma separated#13206
weizhouapache wants to merge 2 commits into
apache:4.22from
weizhouapache:4.22-root-ca-multiple-network-cidrs

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented May 21, 2026

Description

This PR supports multiple network cidrs in Root CA provider.

It is already supported in system vms and VRs.

fixes #13201

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.22.2 milestone May 21, 2026
@weizhouapache weizhouapache force-pushed the 4.22-root-ca-multiple-network-cidrs branch from ffce409 to 0b53714 Compare May 21, 2026 08:55
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 21, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 21, 2026

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.69%. Comparing base (35ac91e) to head (f52077e).

❗ There is a different number of reports uploaded between BASE (35ac91e) and HEAD (f52077e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (35ac91e) HEAD (f52077e)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.22   #13206       +/-   ##
=============================================
- Coverage     17.67%    3.69%   -13.98%     
=============================================
  Files          5922      448     -5474     
  Lines        533121    38105   -495016     
  Branches      65201     7059    -58142     
=============================================
- Hits          94240     1409    -92831     
+ Misses       428236    36509   -391727     
+ Partials      10645      187    -10458
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache
weizhouapache commented May 21, 2026
View reviewed changes
Comment thread plugins/ca/root-ca/src/main/java/org/apache/cloudstack/ca/provider/RootCAProvider.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

2 participants

@weizhouapache @blueorangutan