UI: Fix select search icon orientation in dropdown menu#13170
Open
Damans227 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@Damans227 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13170 +/- ##
============================================
- Coverage 18.09% 18.08% -0.01%
+ Complexity 16723 16718 -5
============================================
Files 6037 6037
Lines 542580 542580
Branches 66427 66427
============================================
- Hits 98155 98136 -19
- Misses 433399 433417 +18
- Partials 11026 11027 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The small search (magnifying glass) icon that appears inside searchable dropdowns was showing up upside down whenever the dropdown was opened. This affected every searchable dropdown across the UI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots:
Before:
After:
How Has This Been Tested?
Opened searchable dropdowns (e.g. the Domain field in "Add new Affinity Group") and confirmed the search icon now appears right-side up. Verified the chevron arrow on regular dropdowns still flips when opened.