Inject the template's download state in the secondary storage selectors#13025
Open
winterhazel wants to merge 1 commit intoapache:4.20from
Open
Inject the template's download state in the secondary storage selectors#13025winterhazel wants to merge 1 commit intoapache:4.20from
winterhazel wants to merge 1 commit intoapache:4.20from
Conversation
Member
Author
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13025 +/- ##
=============================================
- Coverage 16.26% 4.15% -12.11%
=============================================
Files 5665 404 -5261
Lines 500530 32966 -467564
Branches 60787 5893 -54894
=============================================
- Hits 81411 1370 -80041
+ Misses 410027 31420 -378607
+ Partials 9092 176 -8916
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following preset variables to the secondary storage selectors of
TEMPLATEresources:template.isPublictemplate.downloadDetailstemplate.downloadDetails[i].dataStoreIdtemplate.downloadDetails[i].downloadStateUsing them, it is possible to define heuristics to avoid the redownload/copy of public templates, for instance:
The selector above will direct the template to a secondary storage that the template is already present when it is marked as public and downloaded/downloading. Hence, it will not be duplicated to other secondary storages.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
In an environment with a single secondary storage,
sec-nfs-1:sec-nfs-1.sec-nfs-2, and verified that the existing public templates were not copied/downloaded tosec-nfs-2because the secondary storage selector was directing them tosec-nfs-1.