Skip to content

Fix logging of forwarded IPs in logs #11854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishesh92 merged 7 commits into from
Jan 27, 2026
Merged

Fix logging of forwarded IPs in logs #11854

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f331f0f
log the forwarded ip address in access log if the setting proxy.heade…
abh1sar Oct 16, 2025
8879aa8
use static functions from ApiServlet and code refactoring
abh1sar Oct 17, 2025
e9b7ba4
Fix ApiServletTest.java
abh1sar Oct 21, 2025
5a59165
fix precommit
abh1sar Oct 21, 2025
04eb391
fix precommit
abh1sar Oct 21, 2025
7c48df3
Use remoteAddress.getHostAddress()
abh1sar Jan 14, 2026
f418cd8
Merge branch '4.22' into forwarded-ip-accesslog
abh1sar Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use remoteAddress.getHostAddress()
  • Loading branch information
@abh1sar
abh1sar committed Jan 14, 2026
commit 7c48df3ed85fe56df18a3dd022b7050a4e0ae4e9
2 changes: 1 addition & 1 deletion client/src/main/java/org/apache/cloudstack/ACSRequestLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public void log(Request request, Response response) {
sb.setLength(0);

InetAddress remoteAddress = ApiServlet.getClientAddress(request);
sb.append(remoteAddress)
sb.append(remoteAddress.getHostAddress())
.append(" - - [")
.append(dateCache.format(request.getTimeStamp()))
.append("] \"")
Expand Down
Loading