Skip to content

ui: show multiple domains as links in list view #11536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weizhouapache merged 2 commits into from
Sep 3, 2025
Merged

ui: show multiple domains as links in list view #11536

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b999d35
ui: show multiple domains as links in list view
shwstppr Aug 29, 2025
9c3018b
fix
shwstppr Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ui: show multiple domains as links in list view 
Currently, when resources are linked to multiple domains and they are
shown in the list view, they are not clickable. This PR fixes it.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
  • Loading branch information
@shwstppr
shwstppr committed Aug 29, 2025
commit b999d351841a8249c55e7365a66cdb9a97cd469c
16 changes: 15 additions & 1 deletion ui/src/components/view/ListView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,21 @@
<resource-label :resourceType="record.resourcetype" :resourceId="record.resourceid" :resourceName="record.resourcename" />
</template>
<template v-if="column.key === 'domain'">
<router-link v-if="record.domainid && !record.domainid.toString().includes(',') && $store.getters.userInfo.roletype !== 'User'" :to="{ path: '/domain/' + record.domainid, query: { tab: 'details' } }">{{ text }}</router-link>
<span v-if="record.domainid && $store.getters.userInfo.roletype !== 'User'">
<template v-if="record.domainid.toString().includes(',')">
<template v-for="(id, idx) in record.domainid.toString().split(',')" :key="id">
Comment thread
shwstppr marked this conversation as resolved.
Outdated
<router-link :to="{ path: '/domain/' + id, query: { tab: 'details' } }">
{{ record.domain.split(',')[idx] || id }}
</router-link>
<span v-if="idx < record.domainid.split(',').length - 1">, </span>
</template>
</template>
<template v-else>
Comment thread
shwstppr marked this conversation as resolved.
Outdated
<router-link :to="{ path: '/domain/' + record.domainid, query: { tab: 'details' } }">
{{ record.domain || text }}
</router-link>
</template>
</span>
<span v-else>{{ text }}</span>
</template>
<template v-if="column.key === 'domainpath'">
Expand Down
Loading