[4.6/4.6.1] IMPORTANT for 4.6.1 release -- debian: allow rules to pick ACS_BUILD_OPTS from env#1149
[4.6/4.6.1] IMPORTANT for 4.6.1 release -- debian: allow rules to pick ACS_BUILD_OPTS from env#1149yadvr wants to merge 1 commit into
Conversation
Only now debian builds can be noredist etc. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
Test jenkins build job: http://sb.bhaisaab.org:8888/job/deb-shapeblue-build-patch-noredist/103/console |
|
Makes sense, LGTM also based on the successful job above. |
|
Ping @borisroman to have a look |
|
Seems good, LGTM |
|
@bhaisaab Should I merge this to master, or should it be merged to 4.6? |
|
@remibergsma sorry for the source/target branches; this needs to go into both 4.6 and master branches. So merge on 4.6, and fwd-merge 4.6 on master. Thanks. |
|
@remibergsma let me know if you want me to open a new PR against 4.6 branch. |
|
@bhaisaab Check! This I cannot merge to 4.6 with this PR so if you make one against 4.6 that would be easy. Mention this one so it can go through faster. Thanks! |
|
@remibergsma thanks, opened another PR #1169 please merge that. Closing this one, as once the other PR will be merged on 4.6 and 4.6 on master; we won't need this PR anyway. |
debian: allow rules to pick ACS_BUILD_OPTS from envOnly now debian builds can be noredist etc. Old PR: #1149 cc @remibergsma * pr/1169: debian: allow rules to pick ACS_BUILD_OPTS from env Signed-off-by: Remi Bergsma <github@remi.nl>
Only now debian builds can be noredist etc.
cc @remibergsma @wido - I think the apt-get.eu 4.6.0 deb repo was oss and not noredist one. I also checked the jenkins job it does not "export ACS_BUILD_OPTS='-Dnoredist -Dnonoss'" before running dpkg-buildpackage
I discovered this while testing 4.6.1 RC1 today, nothing major just a build profile issue.