Skip to content

Refactoring retention of backup schedules #11223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sureshanaparti merged 5 commits into from
Jul 30, 2025
Merged

Refactoring retention of backup schedules #11223

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3c6b55
refactor backup schedule retention workflows
bernardodemarco Jul 15, 2025
6dbc1c0
change min property for the retention input
bernardodemarco Jul 16, 2025
7aa2edc
Merge branch 'main' into refactor-backup-schedules-retention-workflows
winterhazel Jul 24, 2025
1e8512b
add check before casting
bernardodemarco Jul 29, 2025
2224342
change validation before casting
bernardodemarco Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add check before casting
  • Loading branch information
@bernardodemarco
bernardodemarco committed Jul 29, 2025
commit 1e8512b4164611608edb6f01f9871ce2c88ab497
5 changes: 5 additions & 0 deletions server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
import org.apache.cloudstack.backup.dao.BackupScheduleDao;
import org.apache.cloudstack.context.CallContext;
import org.apache.cloudstack.framework.config.ConfigKey;
import org.apache.cloudstack.framework.jobs.AsyncJob;
import org.apache.cloudstack.framework.jobs.AsyncJobDispatcher;
import org.apache.cloudstack.framework.jobs.AsyncJobManager;
import org.apache.cloudstack.framework.jobs.impl.AsyncJobVO;
Expand Down Expand Up @@ -673,6 +674,10 @@ protected void sendExceededBackupLimitAlert(String ownerUuid, Resource.ResourceT
* @return The backup schedule ID. Returns null if the backup has been manually created
*/
protected Long getBackupScheduleId(Object job) {
if (!(job instanceof AsyncJob)) {
return null;
}

AsyncJobVO asyncJob = (AsyncJobVO) job;
Comment thread
bernardodemarco marked this conversation as resolved.
logger.debug("Trying to retrieve [{}] parameter from the job [ID: {}] parameters.", ApiConstants.SCHEDULE_ID, asyncJob.getId());
String jobParamsRaw = asyncJob.getCmdInfo();
Expand Down
Loading