[4.6] CLOUDSTACK-9083: Add disk serial to kvm virt xml#1121
Merged
Conversation
Adds disk serial ids based on volume uuids to the virt xml. This may be useful for appliances/software that needs some serial ids on the VM disks. This does not impact existing/running VMs, the vm virt xmls will be updates for running VMs the next time they are stopped/started. For testing, disk serial (of debian based systemvm) in the virt xml matched that in /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial. We currently don't support scsi-blcok devices for which serial is not supported, for this we've added a DeviceType (LUN) which may be used in future and a check to not add the serial to the xml if disk type is LUN. Refer: https://libvirt.org/formatdomain.html#elementsDisks Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
Ping @wido @wilderrodrigues @remibergsma |
Contributor
|
LGTM based on these tests: Result: And: Result: @bhaisaab Tests look OK, I didn't test the actual change. |
Contributor
|
Pinging @DaanHoogland @borisroman to do second review. |
Contributor
There was a problem hiding this comment.
So why is the LUN type added here?
Member
Author
There was a problem hiding this comment.
SCSI block devices, LUN are not supported; the type was added to avoid possible bug in case we decide to support this storage/device type in future. See https://libvirt.org/formatdomain.html#elementsDisks for details.
Member
Author
|
Verifying this is simple, just check the in the VM's virt xml (virsh edit domain, note the serial in the xml for the disk/volume) and ssh into the VM and check the hdd/vda serial (on debian based systemvm it was available at /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial) |
Contributor
|
LGTM based on the code. I don't see any real issues. |
Member
Author
|
Merging now that we're tests performed and 2LGTMs. |
asfgit
pushed a commit
that referenced
this pull request
Nov 30, 2015
[4.6] CLOUDSTACK-9083: Add disk serial to kvm virt xmlAdds disk serial ids based on volume uuids to the virt xml. This may be useful for appliances/software that needs some serial ids on the VM disks. This does not impact existing/running VMs, the vm virt xmls will be updates for running VMs the next time they are stopped/started. For testing, disk serial (of debian based systemvm) in the virt xml matched that in /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial. We currently don't support scsi-blcok devices for which serial is not supported, for this we've added a DeviceType (LUN) which may be used in future and a check to not add the serial to the xml if disk type is LUN. Refer: https://libvirt.org/formatdomain.html#elementsDisks * pr/1121: CLOUDSTACK-9083: Add disk serial to kvm virt xml Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Contributor
|
great @bhaisaab I'll create the merge forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds disk serial ids based on volume uuids to the virt xml. This may be useful
for appliances/software that needs some serial ids on the VM disks. This does not
impact existing/running VMs, the vm virt xmls will be updates for running VMs
the next time they are stopped/started.
For testing, disk serial (of debian based systemvm) in the virt xml matched that
in /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial.
We currently don't support scsi-blcok devices for which serial is not supported,
for this we've added a DeviceType (LUN) which may be used in future and a check
to not add the serial to the xml if disk type is LUN.
Refer: https://libvirt.org/formatdomain.html#elementsDisks