Skip to content

Add unit tests for getConfigResources in ModuleDefinitionSet and improve context readability #11042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 3 commits into from
Jul 28, 2025
Merged

Add unit tests for getConfigResources in ModuleDefinitionSet and improve context readability #11042

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee994b3
add test cases for getConfigResources
he1l0world Jun 17, 2025
390ac7b
split tests for each cases
he1l0world Jun 17, 2025
bbd30a3
fix typos
he1l0world Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix typos
  • Loading branch information
@he1l0world
he1l0world committed Jul 9, 2025
commit bbd30a3530529179c17ad1d9d7658c5a34bac2e8
6 changes: 3 additions & 3 deletions .../test/java/org/apache/cloudstack/spring/module/factory/ModuleBasedContextFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public void testChild1ConfigResources() throws IOException {
ModuleDefinitionSet set = factory.loadModules(defs, "base");
testConfigResourcesArray(new String[] {
"child1-context.xml", "child1-context-inheritable.xml",
"base-context-inheritable.xml", "chil1-context-override.xml"
"base-context-inheritable.xml", "child1-context-override.xml"
}, set.getConfigResources("child1"));
}

Expand All @@ -120,10 +120,10 @@ public void testChild2ConfigResources() throws IOException {
}

@Test
public void testChild11ConfigResources() throws IOException {
public void testChild1_1ConfigResources() throws IOException {
ModuleDefinitionSet set = factory.loadModules(defs, "base");
testConfigResourcesArray(new String[] {
"chil1-1-context.xml", "child1-context-inheritable.xml", "base-context-inheritable.xml"
"child1-1-context.xml", "child1-context-inheritable.xml", "base-context-inheritable.xml"
}, set.getConfigResources("child1-1"));
}

Expand Down
0 ...esthierarchy/child1-1/chil1-1-context.xml → ...sthierarchy/child1-1/child1-1-context.xml
View file
Open in desktop
File renamed without changes.
0 ...erarchy/child1/chil1-context-override.xml → ...rarchy/child1/child1-context-override.xml
View file
Open in desktop
File renamed without changes.
Loading