Skip to content

server: fix list diskoffering by domainid returns Inactive offerings #10916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
May 27, 2025
Merged

server: fix list diskoffering by domainid returns Inactive offerings #10916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0970780
server: fix list diskoffering by domainid returns Inactive offerings
weizhouapache May 26, 2025
525e752
Update 10916
weizhouapache May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3485,7 +3485,9 @@

SearchCriteria<DiskOfferingVO> sc = diskOfferingSearch.create();
sc.setParameters("computeOnly", false);
sc.setParameters("activeState", DiskOffering.State.Active);
if (state != null) {
sc.setParameters("state", state);

Check warning on line 3489 in server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L3489 

Added line #L3489 was not covered by tests
}
Comment thread
DaanHoogland marked this conversation as resolved.

sc.setJoinParameters("domainDetailsSearch", "domainId", domainId);

Expand Down
Loading